From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
Date: Sat, 10 Aug 2013 23:36:46 -0400 [thread overview]
Message-ID: <jwv4nawlx3q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAAeL0SS=y0jRR1zfOFKk-bp2cvNsAQJqJzz2GF63aXCm3TsLwA@mail.gmail.com> (Juanma Barranquero's message of "Sat, 10 Aug 2013 21:37:49 +0200")
>> So the problem is in the definition of gv-define-simple-setter.
> It is a problem? It seems quite purposeful.
No, it's just an oversight. Could you fix it to use`funcall'?
> Unrelated to the warning: the old lambda didn't return `time', and
> `gv-define-simple-setter' wasn't passed the fix-return arg.
Good point, thanks,
Stefan
prev parent reply other threads:[~2013-08-11 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V88KF-0002U2-9F@vcs.savannah.gnu.org>
2013-08-10 13:25 ` [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter Stefan Monnier
2013-08-10 13:26 ` Juanma Barranquero
2013-08-10 18:22 ` Stefan Monnier
2013-08-10 19:37 ` Juanma Barranquero
2013-08-11 3:36 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4nawlx3q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).