unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/hyperbole 4382aa9268 2/2: Disable local variables when reading HyRolo files
       [not found] ` <20220829205745.B1035C008FF@vcs2.savannah.gnu.org>
@ 2022-08-29 21:19   ` Stefan Monnier
  0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2022-08-29 21:19 UTC (permalink / raw)
  To: Bob Weiner, emacs-devel

> +    (if (string-match "\\.org$" file)

[ I suspect this should use "\\.org\\'".  ]

> +	(let ((find-file-literally t))
> +	  (hyrolo-find-file file hyrolo-find-file-noselect-function nil t))

What does this `let` do exactly?
I searched docstrings and Texinfo but it doesn't seem to say clearly what
this does.  The `find-file-literally` is documented to set this var in
the resulting buffer, but that's something different.

I guess a first step would be to add a comment here describing what this
code hopes to obtain with this `let-binding`, but maybe Emacs itself
should describe the effect of such a binding (or some other way to get
the same effect).


        Stefan




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-29 21:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <166180666504.30315.462232908228663809@vcs2.savannah.gnu.org>
     [not found] ` <20220829205745.B1035C008FF@vcs2.savannah.gnu.org>
2022-08-29 21:19   ` [elpa] externals/hyperbole 4382aa9268 2/2: Disable local variables when reading HyRolo files Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).