unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bob Weiner <rsw@gnu.org>, emacs-devel@gnu.org
Subject: Re: [elpa] externals/hyperbole 4382aa9268 2/2: Disable local variables when reading HyRolo files
Date: Mon, 29 Aug 2022 17:19:44 -0400	[thread overview]
Message-ID: <jwv4jxuhhsl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220829205745.B1035C008FF@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 29 Aug 2022 16:57:45 -0400 (EDT)")

> +    (if (string-match "\\.org$" file)

[ I suspect this should use "\\.org\\'".  ]

> +	(let ((find-file-literally t))
> +	  (hyrolo-find-file file hyrolo-find-file-noselect-function nil t))

What does this `let` do exactly?
I searched docstrings and Texinfo but it doesn't seem to say clearly what
this does.  The `find-file-literally` is documented to set this var in
the resulting buffer, but that's something different.

I guess a first step would be to add a comment here describing what this
code hopes to obtain with this `let-binding`, but maybe Emacs itself
should describe the effect of such a binding (or some other way to get
the same effect).


        Stefan




           reply	other threads:[~2022-08-29 21:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220829205745.B1035C008FF@vcs2.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4jxuhhsl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rsw@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).