From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/hyperbole 4382aa9268 2/2: Disable local variables when reading HyRolo files Date: Mon, 29 Aug 2022 17:19:44 -0400 Message-ID: References: <166180666504.30315.462232908228663809@vcs2.savannah.gnu.org> <20220829205745.B1035C008FF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Bob Weiner , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 29 23:21:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSmCP-000AYy-So for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 23:21:38 +0200 Original-Received: from localhost ([::1]:48428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSmCN-0008IJ-Pf for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 17:21:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSmAi-00078e-KO for emacs-devel@gnu.org; Mon, 29 Aug 2022 17:19:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSmAf-00081A-Hq; Mon, 29 Aug 2022 17:19:51 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D68B9441E9B; Mon, 29 Aug 2022 17:19:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5BFE0441E82; Mon, 29 Aug 2022 17:19:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661807985; bh=7mlQGcfHSDtxB0CJNS3NVRVjI3ciUdpvk+E3Md5/cAg=; h=From:To:Subject:In-Reply-To:References:Date:From; b=QzOG7AdGxHH8zqqkWU4wMpvHQHOij/OXK/BEQv0GR/vYvQiQowdfY8mhBYx47C2sf 8YVJ4wKxXpmmq2omdmnKLZehBP0FbYTl/wQSds/TbcaGj5bFwGeiXsrIJdzc/NPnlb pIMM3a4q5noopsIDhOIfAt6PSBU+BzBE//dnV5Qe2c2iwt37KM3HGqZjsNFFO56Vpi HpzlJeF34/1PeQIsF4q2j2E9nRh8DKmv5jFeZDdfMLxTGjnl8927ytevzwZlBIX2rz eIdnZ2ka7kOzF6PAV4iI4oUEzVEbsa3H4LZkxq3m0e/oz4RrLDquirZZoDjZdP5xmh /4SXyjiNKsENg== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 39F2A12066C; Mon, 29 Aug 2022 17:19:45 -0400 (EDT) In-Reply-To: <20220829205745.B1035C008FF@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 29 Aug 2022 16:57:45 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294315 Archived-At: > + (if (string-match "\\.org$" file) [ I suspect this should use "\\.org\\'". ] > + (let ((find-file-literally t)) > + (hyrolo-find-file file hyrolo-find-file-noselect-function nil t)) What does this `let` do exactly? I searched docstrings and Texinfo but it doesn't seem to say clearly what this does. The `find-file-literally` is documented to set this var in the resulting buffer, but that's something different. I guess a first step would be to add a comment here describing what this code hopes to obtain with this `let-binding`, but maybe Emacs itself should describe the effect of such a binding (or some other way to get the same effect). Stefan