From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, teirllm@dms.auburn.edu, rms@gnu.org, miles@gnu.org
Subject: Re: file-name-shadow-mode
Date: Mon, 21 Mar 2005 11:58:17 -0500 [thread overview]
Message-ID: <jwv3bupq7pl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <fc339e4a05032106267318b1b1@mail.gmail.com> (Miles Bader's message of "Mon, 21 Mar 2005 23:26:20 +0900")
>> How 'bout the patch below which makes no assumption (that I know of) about
>> substitute-in-file-name, and will thus correctly even with weird
>> magic file name handlers.
> Um, I should note that the original code was designed to be fast and
> not cons unnecessarily, because it runs on every keystroke -- that's
> the reason it uses just a regexp match and a move-overlay. Your
> suggested replacement looks ... less careful.
I'm fully aware of it, of course. Given the binary search, it should around
the loop about 5-7 times, and substitute-in-file-name shouldn't do that much
consing itself, so I figured it was worth trying.
Also we could easily optimize the common case (where the overlay is not
moved) using a total of 3 calls to substitute-in-file-name in the
common case.
But given the fact that icomplete.el has been usable for a long time
already, I suspect that the performance issue is only in our heads,
Stefan
next prev parent reply other threads:[~2005-03-21 16:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 9:16 file-name-shadow-mode David Kastrup
2005-03-17 12:16 ` file-name-shadow-mode Matt Hodges
2005-03-18 1:56 ` file-name-shadow-mode Miles Bader
2005-03-18 1:59 ` file-name-shadow-mode Miles Bader
2005-03-18 2:17 ` file-name-shadow-mode Nick Roberts
2005-03-18 4:35 ` file-name-shadow-mode Luc Teirlinck
2005-03-18 4:47 ` file-name-shadow-mode Stefan Monnier
2005-03-18 4:55 ` file-name-shadow-mode Luc Teirlinck
2005-03-18 5:18 ` file-name-shadow-mode Luc Teirlinck
2005-03-18 5:37 ` file-name-shadow-mode Luc Teirlinck
2005-03-18 18:20 ` file-name-shadow-mode Richard Stallman
2005-03-19 15:21 ` file-name-shadow-mode Luc Teirlinck
2005-03-19 15:45 ` file-name-shadow-mode David Kastrup
2005-03-19 16:45 ` file-name-shadow-mode Stefan Monnier
2005-03-20 2:14 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 14:13 ` file-name-shadow-mode Stefan Monnier
2005-03-20 16:02 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 16:18 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 2:30 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 3:33 ` file-name-shadow-mode Miles Bader
2005-03-20 4:28 ` file-name-shadow-mode David Kastrup
2005-03-20 17:30 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 18:10 ` file-name-shadow-mode David Kastrup
2005-03-21 1:19 ` file-name-shadow-mode Richard Stallman
2005-03-20 18:01 ` file-name-shadow-mode Richard Stallman
2005-03-20 18:24 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 18:47 ` file-name-shadow-mode David Kastrup
2005-03-20 21:11 ` file-name-shadow-mode Luc Teirlinck
2005-03-20 21:25 ` file-name-shadow-mode Luc Teirlinck
2005-03-21 13:44 ` file-name-shadow-mode Stefan Monnier
2005-03-21 22:24 ` file-name-shadow-mode Luc Teirlinck
2005-03-21 23:00 ` file-name-shadow-mode Stefan Monnier
2005-03-22 20:44 ` file-name-shadow-mode Richard Stallman
2005-03-28 21:32 ` file-name-shadow-mode Stefan Monnier
2005-03-21 13:24 ` file-name-shadow-mode Stefan Monnier
2005-03-21 14:05 ` file-name-shadow-mode David Kastrup
2005-03-21 16:48 ` file-name-shadow-mode Stefan Monnier
2005-03-22 3:34 ` file-name-shadow-mode Richard Stallman
2005-03-21 14:26 ` file-name-shadow-mode Miles Bader
2005-03-21 15:14 ` file-name-shadow-mode David Kastrup
2005-03-21 15:47 ` file-name-shadow-mode David Kastrup
2005-03-21 16:58 ` Stefan Monnier [this message]
2005-03-21 23:57 ` file-name-shadow-mode Luc Teirlinck
2005-03-23 22:55 ` file-name-shadow-mode Stefan Monnier
2005-03-24 0:04 ` file-name-shadow-mode David Kastrup
2005-03-25 6:42 ` file-name-shadow-mode Richard Stallman
2005-03-25 8:45 ` file-name-shadow-mode David Kastrup
2005-03-18 5:23 ` file-name-shadow-mode Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv3bupq7pl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=rms@gnu.org \
--cc=teirllm@dms.auburn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).