* Re: master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic
[not found] ` <20190420164015.B91E3207D5@vcs0.savannah.gnu.org>
@ 2019-04-20 17:47 ` Glenn Morris
2019-04-20 18:51 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2019-04-20 17:47 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul Eggert
> commit b3a12c62c9085171866256f00dada4326a4a3084
[...]
> + int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname,
> + "/run/user/%"PRIuMAX, id);
Is it really worth hard-coding assumptions about the base value of
XDG_RUNTIME_DIR in emacsclient? It's a variable, after all.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic
2019-04-20 17:47 ` master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic Glenn Morris
@ 2019-04-20 18:51 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2019-04-20 18:51 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
Glenn Morris wrote:
>> commit b3a12c62c9085171866256f00dada4326a4a3084
> [...]
>> + int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname,
>> + "/run/user/%"PRIuMAX, id);
> Is it really worth hard-coding assumptions about the base value of
> XDG_RUNTIME_DIR in emacsclient? It's a variable, after all.
Although XDG_RUNTIME_DIR is nominally a variable, I don't know of any platform
where it exists with a value that is not /run/user/USERID (or perhaps some
subdirectory of that). If we discover platforms that do things differently we
can generalize the code. In the meantime the patch should be an improvement over
what we had earlier - at least, it was an improvement in my little tests.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-20 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190420164014.25427.23550@vcs0.savannah.gnu.org>
[not found] ` <20190420164015.B91E3207D5@vcs0.savannah.gnu.org>
2019-04-20 17:47 ` master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic Glenn Morris
2019-04-20 18:51 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).