From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic
Date: Sat, 20 Apr 2019 11:51:51 -0700 [thread overview]
Message-ID: <c94e0d3f-804b-abd0-d3fb-eee8843da5e0@cs.ucla.edu> (raw)
In-Reply-To: <1za7gksh55.fsf@fencepost.gnu.org>
Glenn Morris wrote:
>> commit b3a12c62c9085171866256f00dada4326a4a3084
> [...]
>> + int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname,
>> + "/run/user/%"PRIuMAX, id);
> Is it really worth hard-coding assumptions about the base value of
> XDG_RUNTIME_DIR in emacsclient? It's a variable, after all.
Although XDG_RUNTIME_DIR is nominally a variable, I don't know of any platform
where it exists with a value that is not /run/user/USERID (or perhaps some
subdirectory of that). If we discover platforms that do things differently we
can generalize the code. In the meantime the patch should be an improvement over
what we had earlier - at least, it was an improvement in my little tests.
prev parent reply other threads:[~2019-04-20 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190420164014.25427.23550@vcs0.savannah.gnu.org>
[not found] ` <20190420164015.B91E3207D5@vcs0.savannah.gnu.org>
2019-04-20 17:47 ` master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic Glenn Morris
2019-04-20 18:51 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c94e0d3f-804b-abd0-d3fb-eee8843da5e0@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).