From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master b3a12c6: Improve XDG_RUNTIME_DIR diagnostic Date: Sat, 20 Apr 2019 11:51:51 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20190420164014.25427.23550@vcs0.savannah.gnu.org> <20190420164015.B91E3207D5@vcs0.savannah.gnu.org> <1za7gksh55.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27119"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 20 20:55:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHv8l-0006oc-M1 for ged-emacs-devel@m.gmane.org; Sat, 20 Apr 2019 20:55:07 +0200 Original-Received: from localhost ([127.0.0.1]:44347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHv8k-0008L0-M4 for ged-emacs-devel@m.gmane.org; Sat, 20 Apr 2019 14:55:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHv7w-0008Kc-Rb for emacs-devel@gnu.org; Sat, 20 Apr 2019 14:54:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHv5f-0004Ph-0Y for emacs-devel@gnu.org; Sat, 20 Apr 2019 14:51:55 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37550) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHv5e-0004Mh-Qj; Sat, 20 Apr 2019 14:51:54 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EBBD8161816; Sat, 20 Apr 2019 11:51:52 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9zuvggdA7shG; Sat, 20 Apr 2019 11:51:52 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 310C6161817; Sat, 20 Apr 2019 11:51:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BJj3Vh2GSy6N; Sat, 20 Apr 2019 11:51:52 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 065F4161814; Sat, 20 Apr 2019 11:51:52 -0700 (PDT) In-Reply-To: <1za7gksh55.fsf@fencepost.gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235708 Archived-At: Glenn Morris wrote: >> commit b3a12c62c9085171866256f00dada4326a4a3084 > [...] >> + int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname, >> + "/run/user/%"PRIuMAX, id); > Is it really worth hard-coding assumptions about the base value of > XDG_RUNTIME_DIR in emacsclient? It's a variable, after all. Although XDG_RUNTIME_DIR is nominally a variable, I don't know of any platform where it exists with a value that is not /run/user/USERID (or perhaps some subdirectory of that). If we discover platforms that do things differently we can generalize the code. In the meantime the patch should be an improvement over what we had earlier - at least, it was an improvement in my little tests.