From: Randy Taylor <dev@rjt.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rms@gnu.org, rom.skiad@gmail.com, philipk@posteo.net,
emacs-devel@gnu.org
Subject: Re: Should yaml-ts-mode inherit from prog-mode?
Date: Tue, 21 Mar 2023 03:13:07 +0000 [thread overview]
Message-ID: <WqdifAUGptDi-_4vaNs2YbdO4biji6vCKy5d8lkSgDUPXSuvsdmoswQ15NQ2coWHVwiuLQlespicH9vKyWqmjuiij4miDXogA_n4V0pgnGs=@rjt.dev> (raw)
In-Reply-To: <83mt478w48.fsf@gnu.org>
On Monday, March 20th, 2023 at 08:07, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Mon, 20 Mar 2023 01:52:47 +0000
>
> > From: Randy Taylor dev@rjt.dev
> > Cc: rms@gnu.org, Romanos Skiadas rom.skiad@gmail.com, philipk@posteo.net, emacs-devel@gnu.org
> >
> > Eli, do you have any comments?
>
>
> Nothing substantial, no.
>
> > The general consensus seems to be that yaml-ts-mode should inherit from prog-mode instead of
> > text-mode.
> > The arguments in favour make sense to me.
>
>
> That's not my impression. My impression is that there are arguments
> both ways, and therefore the original decision of having it in
> textmodes still stands. The arguments to the contrary were not strong
> enough to justify the move, IMO.
Fair enough.
I originally made yaml-ts-mode inherit from text-mode because the already existing yaml-mode package in MELPA does, and because I was under the impression that prog-mode was meant only for programming languages (as the docstring states). It has since come to my attention that there is not such a strict requirement for deriving from prog-mode, but rather that folks who customize prog-mode would want those customizations applying to the derived mode as well. As many others have stated (for various reasons), I think yaml-ts-mode makes more sense deriving from prog-mode than text-mode (assuming there are no negative consequences of doing so, but I can't think of any).
next prev parent reply other threads:[~2023-03-21 3:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 19:07 Should yaml-ts-mode inherit from prog-mode? Romanos Skiadas
2023-03-03 4:23 ` Richard Stallman
2023-03-04 18:24 ` Romanos Skiadas
2023-03-20 1:52 ` Randy Taylor
2023-03-20 12:07 ` Eli Zaretskii
2023-03-20 14:37 ` Rudolf Schlatte
2023-03-20 16:20 ` Brian Cully via Emacs development discussions.
2023-03-20 16:53 ` Eli Zaretskii
2023-03-21 11:19 ` Jostein Kjønigsen
2023-03-21 13:26 ` Eli Zaretskii
2023-03-21 13:54 ` Rudolf Schlatte
2023-03-21 14:43 ` Yuri Khan
2023-03-21 15:03 ` Rudolf Schlatte
2023-03-22 6:04 ` Yuri Khan
2023-03-22 2:37 ` David Ongaro
2023-03-21 3:13 ` Randy Taylor [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-28 12:24 Romanos Skiadas
2023-02-28 15:52 ` Basil Contovounesios
2023-03-01 14:08 ` Randy Taylor
2023-03-01 14:28 ` Lynn Winebarger
2023-03-01 16:35 ` Vasilij Schneidermann
2023-03-02 12:55 ` Lynn Winebarger
2023-03-02 13:44 ` Philip Kaludercic
2023-03-03 9:00 ` Rudolf Schlatte
2023-03-03 21:58 ` Yuan Fu
2023-03-04 18:45 ` Juri Linkov
2023-02-28 17:50 ` Daniel Fleischer
2023-02-28 17:56 ` Daniel Fleischer
2023-02-28 18:33 ` Dmitry Gutov
2023-03-01 13:35 ` Basil Contovounesios
2023-03-12 2:14 ` Ongaro
2023-03-12 9:20 ` Daniel Fleischer
2023-03-12 12:31 ` Rudolf Schlatte
2023-03-13 8:44 ` Yuri Khan
2023-03-14 1:45 ` David Ongaro
2023-03-01 7:46 ` Matthias Meulien
2023-03-01 13:45 ` Basil Contovounesios
2023-03-07 11:27 ` Jostein Kjønigsen
2023-03-07 14:28 ` Matthias Meulien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='WqdifAUGptDi-_4vaNs2YbdO4biji6vCKy5d8lkSgDUPXSuvsdmoswQ15NQ2coWHVwiuLQlespicH9vKyWqmjuiij4miDXogA_n4V0pgnGs=@rjt.dev' \
--to=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
--cc=rms@gnu.org \
--cc=rom.skiad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).