unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: jostein@kjonigsen.net
Cc: rudi@constantly.at, emacs-devel@gnu.org
Subject: Re: Should yaml-ts-mode inherit from prog-mode?
Date: Tue, 21 Mar 2023 15:26:28 +0200	[thread overview]
Message-ID: <83ileu6xrv.fsf@gnu.org> (raw)
In-Reply-To: <aa84be8d-9ca5-8404-dba5-559c41900476@secure.kjonigsen.net> (message from Jostein Kjønigsen on Tue, 21 Mar 2023 12:19:31 +0100)

> Date: Tue, 21 Mar 2023 12:19:31 +0100
> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
> 
> On 3/20/23 15:37, Rudolf Schlatte wrote:
> >
> > Let me try one last argument for making the switch to prog-mode.  Put
> > the following yaml fragment into a file and hit M-q ("fill-paragraph").
> > This destroys the yaml structure:
> >
> > Before fill-paragraph:
> >
> >      jobs:
> >        check:
> >          runs-on: ubuntu-latest
> >          strategy:
> >            fail-fast: false
> >            matrix:
> >              emacs_version:
> >                - 27.1
> >                - 27.2
> >                - 28.1
> >                - 28.2
> >
> > After fill-paragraph:
> >
> >      jobs: check: runs-on: ubuntu-latest strategy: fail-fast: false matrix:
> >        emacs_version: - 27.1 - 27.2 - 28.1 - 28.2
> >
> Following up on this exact use-case, due to my text-mode hooks, using 
> yaml-ts-mode many times ended up with causing invalid YAML or breaking 
> existing YAML-files.
> 
> I was pretty sure yaml-ts-mode itself was buggy and actually started 
> using fundamental-mode to edit yaml-files instead, until I realized what 
> was going on.
> 
> == Yes. The user-experience was literally that bad. ==
> 
> Lots of people are going to have lots of problems and breakage when 
> using yaml-ts-mode as it is today, deriving from text-mode.
> 
> I plea from the bottom of my heart that we allow a change to prog-mode.

We should instead fix yaml-ts-mode by providing a proper
fill-paragraph-function for it.  No one said that the default
text-mode one will do TRT.



  reply	other threads:[~2023-03-21 13:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 19:07 Should yaml-ts-mode inherit from prog-mode? Romanos Skiadas
2023-03-03  4:23 ` Richard Stallman
2023-03-04 18:24   ` Romanos Skiadas
2023-03-20  1:52     ` Randy Taylor
2023-03-20 12:07       ` Eli Zaretskii
2023-03-20 14:37         ` Rudolf Schlatte
2023-03-20 16:20           ` Brian Cully via Emacs development discussions.
2023-03-20 16:53           ` Eli Zaretskii
2023-03-21 11:19           ` Jostein Kjønigsen
2023-03-21 13:26             ` Eli Zaretskii [this message]
2023-03-21 13:54               ` Rudolf Schlatte
2023-03-21 14:43                 ` Yuri Khan
2023-03-21 15:03                   ` Rudolf Schlatte
2023-03-22  6:04                     ` Yuri Khan
2023-03-22  2:37           ` David Ongaro
2023-03-21  3:13         ` Randy Taylor
  -- strict thread matches above, loose matches on Subject: below --
2023-02-28 12:24 Romanos Skiadas
2023-02-28 15:52 ` Basil Contovounesios
2023-03-01 14:08   ` Randy Taylor
2023-03-01 14:28     ` Lynn Winebarger
2023-03-01 16:35     ` Vasilij Schneidermann
2023-03-02 12:55       ` Lynn Winebarger
2023-03-02 13:44       ` Philip Kaludercic
2023-03-03  9:00         ` Rudolf Schlatte
2023-03-03 21:58           ` Yuan Fu
2023-03-04 18:45             ` Juri Linkov
2023-02-28 17:50 ` Daniel Fleischer
2023-02-28 17:56 ` Daniel Fleischer
2023-02-28 18:33   ` Dmitry Gutov
2023-03-01 13:35     ` Basil Contovounesios
2023-03-12  2:14   ` Ongaro
2023-03-12  9:20     ` Daniel Fleischer
2023-03-12 12:31       ` Rudolf Schlatte
2023-03-13  8:44       ` Yuri Khan
2023-03-14  1:45       ` David Ongaro
2023-03-01  7:46 ` Matthias Meulien
2023-03-01 13:45   ` Basil Contovounesios
2023-03-07 11:27     ` Jostein Kjønigsen
2023-03-07 14:28       ` Matthias Meulien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ileu6xrv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jostein@kjonigsen.net \
    --cc=rudi@constantly.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).