From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.devel Subject: Re: Should yaml-ts-mode inherit from prog-mode? Date: Tue, 21 Mar 2023 03:13:07 +0000 Message-ID: References: <83mt478w48.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36206"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org, rom.skiad@gmail.com, philipk@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 04:14:10 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peSRt-0009AH-Si for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 04:14:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peSR5-0007OK-SC; Mon, 20 Mar 2023 23:13:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peSR4-0007O6-6t for emacs-devel@gnu.org; Mon, 20 Mar 2023 23:13:18 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peSR1-0005AM-Mc for emacs-devel@gnu.org; Mon, 20 Mar 2023 23:13:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1679368391; x=1679627591; bh=FAAjB1IhtXDAP/7UkL546cXxQpBACigKVQukRSX3S6Y=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=2+UkNKTwEvu+Miw2/0GpCjKIEz9K7SFKFDqzwpq3h8WPqQZvxN1PlXdcpQK4WFSge 1f626m7Gn7b2ogJ2BZHRlq5EX/wevzFdBntIo9mPyxW8e9lp+m6CuXaO+MFnSmtXyn fAj4qqJetBtdatI8BaMYfKliAN6Rd+Ymqs1cWxj07CXtGq1Rj48VnLDYPRKKWcGsWi Fe/zfAD/bcqktjo+CRUXEwTpDlPw/gP2nljtciiQBsXm2MjGif+1S1qn7dpKryYYV3 B0mT0igNHu4/dWuku8CntZkQK7Mtzx6mhEYFHFz0p1KivDAOFVs7nChzH50v41MixT lmDSaHUnjgRow== In-Reply-To: <83mt478w48.fsf@gnu.org> Feedback-ID: 44397038:user:proton Received-SPF: pass client-ip=185.70.43.23; envelope-from=dev@rjt.dev; helo=mail-4323.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304625 Archived-At: On Monday, March 20th, 2023 at 08:07, Eli Zaretskii wrote: > > Date: Mon, 20 Mar 2023 01:52:47 +0000 >=20 > > From: Randy Taylor dev@rjt.dev > > Cc: rms@gnu.org, Romanos Skiadas rom.skiad@gmail.com, philipk@posteo.ne= t, emacs-devel@gnu.org > >=20 > > Eli, do you have any comments? >=20 >=20 > Nothing substantial, no. >=20 > > The general consensus seems to be that yaml-ts-mode should inherit from= prog-mode instead of > > text-mode. > > The arguments in favour make sense to me. >=20 >=20 > That's not my impression. My impression is that there are arguments > both ways, and therefore the original decision of having it in > textmodes still stands. The arguments to the contrary were not strong > enough to justify the move, IMO. Fair enough. I originally made yaml-ts-mode inherit from text-mode because the already e= xisting yaml-mode package in MELPA does, and because I was under the impres= sion that prog-mode was meant only for programming languages (as the docstr= ing states). It has since come to my attention that there is not such a str= ict requirement for deriving from prog-mode, but rather that folks who cust= omize prog-mode would want those customizations applying to the derived mod= e as well. As many others have stated (for various reasons), I think yaml-t= s-mode makes more sense deriving from prog-mode than text-mode (assuming th= ere are no negative consequences of doing so, but I can't think of any).