* Do you really mean to call `cl--generic-prefill-dispatchers' twice?
@ 2019-04-03 22:45 Tadeus Prastowo
2019-04-04 16:04 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Tadeus Prastowo @ 2019-04-03 22:45 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Hi Stefan,
While looking at the diff of commit
cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk:
-- 8< ----------------------
@@ -1205,6 +1209,7 @@ See the full list and their hierarchy in
`cl--generic-typeof-types'."
(cl-call-next-method)))
(cl--generic-prefill-dispatchers 0 integer)
+(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer)
;;; Dispatch on major mode.
-- 8< ----------------------
Why didn't you delete the first call `(cl--generic-prefill-dispatchers
0 integer)'?
Thanks.
--
Best regards,
Tadeus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice?
2019-04-03 22:45 Do you really mean to call `cl--generic-prefill-dispatchers' twice? Tadeus Prastowo
@ 2019-04-04 16:04 ` Stefan Monnier
2019-04-04 17:14 ` Tadeus Prastowo
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2019-04-04 16:04 UTC (permalink / raw)
To: Tadeus Prastowo; +Cc: emacs-devel
> While looking at the diff of commit
> cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk:
> -- 8< ----------------------
> @@ -1205,6 +1209,7 @@ See the full list and their hierarchy in
> `cl--generic-typeof-types'."
> (cl-call-next-method)))
>
> (cl--generic-prefill-dispatchers 0 integer)
> +(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer)
>
> ;;; Dispatch on major mode.
>
> -- 8< ----------------------
>
> Why didn't you delete the first call `(cl--generic-prefill-dispatchers
> 0 integer)'?
Either because:
- There are still methods defined in the preloaded packages which do
dispatch on a first argument that's `integer`.
- I didn't bother to check whether there are still such methods.
I can't remember which. If you've check that there aren't such methods
left, then we could remove it, indeed.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice?
2019-04-04 16:04 ` Stefan Monnier
@ 2019-04-04 17:14 ` Tadeus Prastowo
0 siblings, 0 replies; 3+ messages in thread
From: Tadeus Prastowo @ 2019-04-04 17:14 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On Thu, Apr 4, 2019 at 6:04 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > While looking at the diff of commit
> > cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk:
> > -- 8< ----------------------
> > @@ -1205,6 +1209,7 @@ See the full list and their hierarchy in
> > `cl--generic-typeof-types'."
> > (cl-call-next-method)))
> >
> > (cl--generic-prefill-dispatchers 0 integer)
> > +(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer)
> >
> > ;;; Dispatch on major mode.
> >
> > -- 8< ----------------------
> >
> > Why didn't you delete the first call `(cl--generic-prefill-dispatchers
> > 0 integer)'?
>
> Either because:
> - There are still methods defined in the preloaded packages which do
> dispatch on a first argument that's `integer`.
> - I didn't bother to check whether there are still such methods.
> I can't remember which. If you've check that there aren't such methods
> left, then we could remove it, indeed.
Thank you very much for your comment. I wanted to make sure that the
line was not left by accident.
> Stefan
--
Best regards,
Tadeus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-04 17:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 22:45 Do you really mean to call `cl--generic-prefill-dispatchers' twice? Tadeus Prastowo
2019-04-04 16:04 ` Stefan Monnier
2019-04-04 17:14 ` Tadeus Prastowo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).