From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice? Date: Thu, 04 Apr 2019 12:04:31 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225287"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: Tadeus Prastowo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 04 18:05:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC4rv-000wRa-BH for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 18:05:35 +0200 Original-Received: from localhost ([127.0.0.1]:57040 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC4ru-00046x-DD for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 12:05:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC4r6-00045i-6E for emacs-devel@gnu.org; Thu, 04 Apr 2019 12:04:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hC4r2-0007B8-Bz for emacs-devel@gnu.org; Thu, 04 Apr 2019 12:04:42 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC4r0-0006zb-8m for emacs-devel@gnu.org; Thu, 04 Apr 2019 12:04:40 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x34G4V8I017921; Thu, 4 Apr 2019 12:04:32 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 74793AE275; Thu, 4 Apr 2019 12:04:31 -0400 (EDT) In-Reply-To: (Tadeus Prastowo's message of "Thu, 4 Apr 2019 00:45:24 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6518=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6518> : inlines <7047> : streams <1817696> : uri <2825828> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234955 Archived-At: > While looking at the diff of commit > cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk: > -- 8< ---------------------- > @@ -1205,6 +1209,7 @@ See the full list and their hierarchy in > `cl--generic-typeof-types'." > (cl-call-next-method))) > > (cl--generic-prefill-dispatchers 0 integer) > +(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer) > > ;;; Dispatch on major mode. > > -- 8< ---------------------- > > Why didn't you delete the first call `(cl--generic-prefill-dispatchers > 0 integer)'? Either because: - There are still methods defined in the preloaded packages which do dispatch on a first argument that's `integer`. - I didn't bother to check whether there are still such methods. I can't remember which. If you've check that there aren't such methods left, then we could remove it, indeed. Stefan