From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tadeus Prastowo Newsgroups: gmane.emacs.devel Subject: Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice? Date: Thu, 4 Apr 2019 19:14:51 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32228"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 04 19:15:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC5xz-0008Ez-W1 for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 19:15:56 +0200 Original-Received: from localhost ([127.0.0.1]:57769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC5xy-0000wf-Vd for ged-emacs-devel@m.gmane.org; Thu, 04 Apr 2019 13:15:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC5xD-0000w7-Nm for emacs-devel@gnu.org; Thu, 04 Apr 2019 13:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hC5xC-0002K5-I8 for emacs-devel@gnu.org; Thu, 04 Apr 2019 13:15:07 -0400 Original-Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]:36171) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hC5xB-0002DK-Tq for emacs-devel@gnu.org; Thu, 04 Apr 2019 13:15:06 -0400 Original-Received: by mail-io1-xd31.google.com with SMTP id f6so2677185iop.3 for ; Thu, 04 Apr 2019 10:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn.it; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bn2CZWwbvXKvBJnS1/vhCVshizJfHEA7zl4ib7Zs7G0=; b=madut3w6fdBRTcQd+U4+WrQ5MoA5QVKoiYV+czn0KXByZ+iNAuHMG0GYTs7L33WOXx W5DFNGSdru3XOyPjhKu3gfp9dQlycC1ZJD9C8whWd9R8JNZh7efWsn89hFw5J+ZF65wp ZAZT2vW+IAPHQI6u7zcvOIXpZZV/YJht/WD0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bn2CZWwbvXKvBJnS1/vhCVshizJfHEA7zl4ib7Zs7G0=; b=V1bF0KEZBjwbOXWDhTFDLFdfWVJLe7Wb7SWEqUwKq6ZsxEJfCUXCME1xAtR53YX9oe omON/5DsNB5CzHU6R1nGXNjdPZsXresb3tiytZfLT8vF16eLWL91DQQAGzAsMJ00hKHP dxfp7RkaMOPiGm9F/mRRNlmPk/z4p48TqKo8GNyzNoj/LGcTD3ZvBSAsPtCHkBc+QyQF BrOdevkX4dLXmvhM3nWqqWLH5Kv/nYShE1ykPtTpGBuvtTVNoLgeEHn6zBjRFCW6pbug c+d9tFb7LRP5hxWSoXdFwU8OnH7N8TIozYo+aVqgiztVY0mareXXulNRC1BkYyEhKOSO ro0g== X-Gm-Message-State: APjAAAVyQrNFW2TqgnNCjaR4n5fmx0Agg48+mhSSVfzsggF5hum6e6o7 4pAPxFuzbk2JrpyMFjI5W8jUXmflEbvCyG5vKWvs X-Google-Smtp-Source: APXvYqz77qZLNRDxabLWVvz1KZ7Mb1VohQRLPPIjbaJ0ch6ppagfWHGQJLY1CGDstbpf+awXctjapcBtG+bKJoXZTjQ= X-Received: by 2002:a5d:8c98:: with SMTP id g24mr5351957ion.35.1554398104199; Thu, 04 Apr 2019 10:15:04 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d31 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234957 Archived-At: On Thu, Apr 4, 2019 at 6:04 PM Stefan Monnier wrote: > > > While looking at the diff of commit > > cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk: > > -- 8< ---------------------- > > @@ -1205,6 +1209,7 @@ See the full list and their hierarchy in > > `cl--generic-typeof-types'." > > (cl-call-next-method))) > > > > (cl--generic-prefill-dispatchers 0 integer) > > +(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer) > > > > ;;; Dispatch on major mode. > > > > -- 8< ---------------------- > > > > Why didn't you delete the first call `(cl--generic-prefill-dispatchers > > 0 integer)'? > > Either because: > - There are still methods defined in the preloaded packages which do > dispatch on a first argument that's `integer`. > - I didn't bother to check whether there are still such methods. > I can't remember which. If you've check that there aren't such methods > left, then we could remove it, indeed. Thank you very much for your comment. I wanted to make sure that the line was not left by accident. > Stefan -- Best regards, Tadeus