unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: Danny Freeman <danny@dfreeman.email>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: eglot--spinner
Date: Sat, 19 Nov 2022 11:24:04 +0000	[thread overview]
Message-ID: <CALDnm53YfHV+68aNR9YEKEi28BcOB3Ynxn9PzjNEN+5dDohPDw@mail.gmail.com> (raw)
In-Reply-To: <86h6yvmgl2.fsf@stephe-leake.org>

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On Sat, Nov 19, 2022 at 9:36 AM Stephen Leake <
stephen_leake@stephe-leake.org> wrote:

> João Távora <joaotavora@gmail.com> writes:
>
> > Hi Stephen,
> >
> > Look in the bug tracker: there's someone implementing a better
> > progress indicator with an implementation that looks very good
> > from what I've seen so far and uses LSP interfaces.
> >
> > Here it is: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59149
> >
> > We can/should try to coalesce the "eglot--spinner" with that.
>
> That is better than using the mode-line, and meets my needs.
>
> So I suggest we just delete eglot--spinner.


I'd say you're right, I can't find a use for it atm.  Also delete the part
of the mode-line updating where it is consulted, as that is basically
dead code right now.

IIRC it was used when there was some RLS-specific code
that informed the user that RLS was not ready for some LSP
requests yet.

Perhaps we can still think of putting the progress indication resulting
from Danny's patch in the Eglot-specific mode-line section.

João

[-- Attachment #2: Type: text/html, Size: 1737 bytes --]

  reply	other threads:[~2022-11-19 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  8:27 eglot--spinner Stephen Leake
2022-11-18  8:48 ` eglot--spinner João Távora
2022-11-18 13:28   ` eglot--spinner Danny Freeman
2022-11-19  9:36   ` eglot--spinner Stephen Leake
2022-11-19 11:24     ` João Távora [this message]
2022-11-20 21:46       ` eglot--spinner Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53YfHV+68aNR9YEKEi28BcOB3Ynxn9PzjNEN+5dDohPDw@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=danny@dfreeman.email \
    --cc=emacs-devel@gnu.org \
    --cc=stephen_leake@stephe-leake.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).