From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: eglot--spinner Date: Sat, 19 Nov 2022 11:24:04 +0000 Message-ID: References: <86r0y07jlw.fsf@stephe-leake.org> <86h6yvmgl2.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009fd82605edd10bec" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12186"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Danny Freeman , emacs-devel To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 12:23:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owLwx-0002z7-Fn for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 12:23:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owLwB-0007JQ-K9; Sat, 19 Nov 2022 06:23:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owLwA-0007J1-5u for emacs-devel@gnu.org; Sat, 19 Nov 2022 06:23:06 -0500 Original-Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owLw8-0005hP-4P for emacs-devel@gnu.org; Sat, 19 Nov 2022 06:23:05 -0500 Original-Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-13c2cfd1126so8832800fac.10 for ; Sat, 19 Nov 2022 03:23:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k3s/PeOrZGQ5hbnxipVTB1oX76zeM2ThxbRMWClTAc8=; b=b8XsrnDzyw5UFj2mLhgxD7ce5KT2S8jMhZZSzRqK7dDd9nh7Ju22lVlI7tdDYv8p1c 5prxw9nSTQ7X717ZiDzfcf5wNG7QmFb2teaWR+eqHVWhCWlys30KddWYJqlRUIOTXiql pPYGoyqbAOkWc6M7jk63Ahx3Jgaa0maCPfkpJW0xaePa3G4NBIbB7XzkHS299j1MGq9X KjmmTS72OVynuhz0/OBWXcmfyc+vnZT3MQhTSOt/pQdbtWn/nwG2EWoz9J0yU3dxt1oK QyqJ03msP2eZgdvgLe3IHPqajVsNDPr08i9DKAKegJMyqnQcxDt1ombHxYOVnwYwFb63 gW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k3s/PeOrZGQ5hbnxipVTB1oX76zeM2ThxbRMWClTAc8=; b=PMoTakBrD37eVMZwu4GwHEwX0V1sDxeUCtxQ0UBTLhYvittw4uTIB3NQOaAv5rJ544 FjSkmV65nXXM+wyk3++EogTvABC+rMGOs0kHhrspPKOft9V2rSgEO5L/AJzVal0x73k7 E5no83OB4xH4sISzNvlWkDVrN6WvklJAOFZ4HuTiJBq6WFeh5h4Nz6uYY23hOpktQxHk LtFY/KMaMHIUYy0SP4bz+8s8lHDgORZGxDrqq+1qhU8PqEjiCJWn0E9dfhSI4RKtQTdA 9t9/86qlWXgGh0zm68R7IUKz8FRvGRNeoMryNdYL+f4Kw50m5yhYxHjAppyAlsTn6Fqf 3mKA== X-Gm-Message-State: ANoB5plf5L8VPZZsxTYHMYV138FeN9D40bYT9+7AbFfRJw54y31ujjk9 siLLiyjABaBdIZMqArnw/1Y3a+8MThvpEWPzMXIoVoH21oU= X-Google-Smtp-Source: AA0mqf79+ULf2rxbh/9CsbarsSBEjrMbMDTUx9XIpCR6FNTDxVhZLgRdIoQTuXj8W4snw/u480+81po1LjLBLkdFvgg= X-Received: by 2002:a05:6870:6688:b0:13b:5ffe:ff70 with SMTP id ge8-20020a056870668800b0013b5ffeff70mr8781601oab.171.1668856982524; Sat, 19 Nov 2022 03:23:02 -0800 (PST) In-Reply-To: <86h6yvmgl2.fsf@stephe-leake.org> Received-SPF: pass client-ip=2001:4860:4864:20::33; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300154 Archived-At: --0000000000009fd82605edd10bec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Nov 19, 2022 at 9:36 AM Stephen Leake < stephen_leake@stephe-leake.org> wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Hi Stephen, > > > > Look in the bug tracker: there's someone implementing a better > > progress indicator with an implementation that looks very good > > from what I've seen so far and uses LSP interfaces. > > > > Here it is: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59149 > > > > We can/should try to coalesce the "eglot--spinner" with that. > > That is better than using the mode-line, and meets my needs. > > So I suggest we just delete eglot--spinner. I'd say you're right, I can't find a use for it atm. Also delete the part of the mode-line updating where it is consulted, as that is basically dead code right now. IIRC it was used when there was some RLS-specific code that informed the user that RLS was not ready for some LSP requests yet. Perhaps we can still think of putting the progress indication resulting from Danny's patch in the Eglot-specific mode-line section. Jo=C3=A3o --0000000000009fd82605edd10bec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Nov 19, 2022 at 9:36 AM Stephen L= eake <stephen_leake@st= ephe-leake.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com= > writes:

> Hi Stephen,
>
> Look in the bug tracker: there's someone implementing a better
> progress indicator with an implementation that looks very good
> from what I've seen so far and uses LSP interfaces.
>
> Here it is: https://debbugs.gnu.org/cgi/= bugreport.cgi?bug=3D59149
>
> We can/should try to coalesce the "eglot--spinner" with that= .

That is better than using the mode-line, and meets my needs.

So I suggest we just delete eglot--spinner.

I'd say you're right, I can't find a use for it atm.=C2=A0 Als= o delete the part
of the mode-line updating where it is consulted= , as that is basically
dead code right now.

IIRC it was used when there was some RLS-specific code
that informed the user that RLS was not ready for some LSP
requests yet.

Perhaps we can still think of putt= ing the progress indication resulting
from Danny's patch in t= he Eglot-specific mode-line section.

Jo=C3=A3o
=
--0000000000009fd82605edd10bec--