From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Cc: "João Távora" <joaotavora@gmail.com>
Subject: eglot--spinner
Date: Fri, 18 Nov 2022 00:27:39 -0800 [thread overview]
Message-ID: <86r0y07jlw.fsf@stephe-leake.org> (raw)
The only uses of eglot--spinner in eglot.el are:
eglot--mode-line-format, where it is added to the mode line.
eglot--signal-textDocument/didChange, where it is set to (list nil
:textDocument/didChange t), meaning didChange is done. Because this is
set to done, it is not actually displayed in the modeline.
For ada-mode, I'd like to use eglot--spinner to show "indexing"
progress; the server is parsing all the files in the project, collecting
cross reference information, which takes a while. The user needs to know
when it is done; then they can use cross reference commands.
So I'd like to delete setting eglot--spinner in
eglot--signal-textDocument/didChange; otherwise that will overwrite the
indexing progress when a buffer is edited.
This would also imply making eglot--spinner public.
That then raises the issue of future conflicting uses of eglot-spinner.
So perhaps it would be better for ada-mode to add another item to the
mode line? To do that requires a hook in eglot--mode-line-format, so it
is grouped with the other eglot-derived mode line items.
--
-- Stephe
next reply other threads:[~2022-11-18 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 8:27 Stephen Leake [this message]
2022-11-18 8:48 ` eglot--spinner João Távora
2022-11-18 13:28 ` eglot--spinner Danny Freeman
2022-11-19 9:36 ` eglot--spinner Stephen Leake
2022-11-19 11:24 ` eglot--spinner João Távora
2022-11-20 21:46 ` eglot--spinner Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0y07jlw.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).