unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Anders Lindgren <andlind@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: Randy Bush <randy@psg.com>, Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke
Date: Mon, 29 Aug 2016 11:37:45 +0200	[thread overview]
Message-ID: <CABr8ebaDj6cd3K9hZtvnLWHBU2T4vbC6x0sFnXs5SaJhQoB0bQ@mail.gmail.com> (raw)
In-Reply-To: <CABGBtwnwZx0nSopXWd5Vkz_+FiP+T7sPcmqVggNfL+x4F6akXw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

>
> On 26 August 2016 at 19:21, Alan Third <alan@idiocy.org> wrote:
> I've had a look about and am currently none the wiser. Is there a standard
> way of handling this sort of thing in C code? Is it just a case of putting
> some sort of SYMBOLP check in before the variable is used or should we
> be able to handle a string instead of a symbol?
>

I would say that we should ensure that Emacs doesn't crash, but it should
ignore all non-symbol values, like most other configuration variables do.

Allowing strings would make the code more complex and it would make testing
harder etc, without giving us any advantages.

The important thing, however, is that the documentation clearly states that
a symbol should be used.

    -- Anders

[-- Attachment #2: Type: text/html, Size: 1129 bytes --]

  parent reply	other threads:[~2016-08-29  9:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  9:04 Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke Randy Bush
2016-08-25 15:08 ` Alan Third
2016-08-25 19:10   ` Randy Bush
2016-08-25 22:38     ` Alan Third
2016-08-26  0:32       ` Randy Bush
2016-08-26  3:11       ` Randy Bush
2016-08-26 18:21         ` Alan Third
2016-08-26 19:26           ` Robert Weiner
2016-08-29  9:28           ` Alan Third
2016-08-29  9:31             ` Randy Bush
2016-08-29  9:37             ` Anders Lindgren [this message]
2016-08-29 13:19             ` Stefan Monnier
2016-08-29 14:32             ` Eli Zaretskii
2016-08-29 18:37               ` Alan Third
  -- strict thread matches above, loose matches on Subject: below --
2016-08-25 10:04 Randy Bush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABr8ebaDj6cd3K9hZtvnLWHBU2T4vbC6x0sFnXs5SaJhQoB0bQ@mail.gmail.com \
    --to=andlind@gmail.com \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=randy@psg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).