From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.devel Subject: Re: Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke Date: Mon, 29 Aug 2016 11:37:45 +0200 Message-ID: References: <20160825223858.GA51405@breton.holly.idiocy.org> <20160826182149.GA51596@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1142cfc2cfb2ec053b329d50 X-Trace: blaine.gmane.org 1472463482 16630 195.159.176.226 (29 Aug 2016 09:38:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Aug 2016 09:38:02 +0000 (UTC) Cc: Randy Bush , Emacs-Devel devel To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 29 11:37:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beJ0v-0003tJ-Hv for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 11:37:57 +0200 Original-Received: from localhost ([::1]:42504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beJ0t-00032G-5Y for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 05:37:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beJ0m-00032B-Uf for emacs-devel@gnu.org; Mon, 29 Aug 2016 05:37:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beJ0k-0001N6-U4 for emacs-devel@gnu.org; Mon, 29 Aug 2016 05:37:47 -0400 Original-Received: from mail-ua0-x231.google.com ([2607:f8b0:400c:c08::231]:34969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beJ0k-0001Mv-NY for emacs-devel@gnu.org; Mon, 29 Aug 2016 05:37:46 -0400 Original-Received: by mail-ua0-x231.google.com with SMTP id i32so65906113uai.2 for ; Mon, 29 Aug 2016 02:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EsMoATeeS50Z4PajjijJCqyxwqOzAa89DpSXvV7yox8=; b=0dQqUv9rJPl9LsaKk/3vN/gcWovYoH0hQUztZ/gvQmjVFIj1JH4NF7qX0C9MM218yb Ads4bruKhakc1eqNwrd4jYuWC535W4cxUqNbQPlrgUaCtnj1HsOiZr+NMj3HoK17DvG4 UrGWTJNpWD/7rp850m7lIZn7jaJ6MBYv2WY0iVPofp8SqoaT00EoyvLSgPico/Bjc83w m9A2BfY28boL2G10gts1fJOyzd2a7X1vbG58QQ7lcpAgg4p4XyHXYIiQRs+iPrTrpfOE XS8+iEqifn54h3EbBMT2KoaTajYBsSbZkc13lTkFcRwKUVvFxQfPD/qus6TldqJcE+Fl P3CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EsMoATeeS50Z4PajjijJCqyxwqOzAa89DpSXvV7yox8=; b=OGGHeMiwEMD/KiFnNMJLbczkhd1FC4383td8XQoBdUAfZRF30mwPQQ7emkXkwySU8p rOOhUKO48W7qPCFSsICqw0OY8T0Nzb9sUvhy1knwQOc9OQcE8XNB7r11/xkU/i2tx865 33hXbD2mApQqI7A7vXQPdj8GvahdtJNx0mQT7kduXRjTSjPP2kAvL+lB9M1vznT1Z+/c kvrePj5YF4v3J1cJJG8OjKCariPvm/qvhnV6hYAD4ewT6LgM3Jl5A0SAK+XtQG1zNone O1nDaE3kE+OKouGWg41Um8OSRYNLNIUsFjd8vAq0LKST4w3mkSYzrJY22WxPVLoT2U/2 eWVg== X-Gm-Message-State: AE9vXwP91s0L1t5bFE2qW+qlRivUUG4S7n7fvQvpzMXo0xjlbSwrqybz3ugScYtrZsreRC1b3VTh2Em10UP0Bg== X-Received: by 10.31.108.156 with SMTP id j28mr9170184vki.68.1472463465587; Mon, 29 Aug 2016 02:37:45 -0700 (PDT) Original-Received: by 10.31.180.148 with HTTP; Mon, 29 Aug 2016 02:37:45 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206863 Archived-At: --001a1142cfc2cfb2ec053b329d50 Content-Type: text/plain; charset=UTF-8 > > On 26 August 2016 at 19:21, Alan Third wrote: > I've had a look about and am currently none the wiser. Is there a standard > way of handling this sort of thing in C code? Is it just a case of putting > some sort of SYMBOLP check in before the variable is used or should we > be able to handle a string instead of a symbol? > I would say that we should ensure that Emacs doesn't crash, but it should ignore all non-symbol values, like most other configuration variables do. Allowing strings would make the code more complex and it would make testing harder etc, without giving us any advantages. The important thing, however, is that the documentation clearly states that a symbol should be used. -- Anders --001a1142cfc2cfb2ec053b329d50 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 26 August 2016 at 19:21, Ala= n Third <alan@idiocy.org> wrot= e:
I've had a look about and am currently none the wiser. Is = there a standard
way of handling this sort of thing in C code? Is it just a case of putting<= br> some sort of SYMBOLP check in before the variable is used or should we
be able to handle a string instead of a symbol?

I would say that we should ensure that Emacs doesn't crash, bu= t it should ignore all non-symbol values, like most other configuration var= iables do.

Allowing strings would make the code mo= re complex and it would make testing harder etc, without giving us any adva= ntages.

The important thing, however, is that the = documentation clearly states that a symbol should be used.

=C2=A0 =C2=A0 -- Anders

--001a1142cfc2cfb2ec053b329d50--