Re: Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke

[Eli Zaretskii <eliz@gnu.org>]

> From: Alan Third <alan@idiocy.org>
> Date: Mon, 29 Aug 2016 10:28:38 +0100
> Cc: Emacs-Devel devel <emacs-devel@gnu.org>
> 
> On 26 August 2016 at 19:21, Alan Third <alan@idiocy.org> wrote:
> > As a quick fix for you, Randy, instead of using "alt", use 'alt. That
> > works as you’d expect. I still need to work out why this crashes,
> > though. Presumably something somewhere is looking for a symbol and
> > really doesn’t like getting a string instead.
> 
> I've had a look about and am currently none the wiser. Is there a standard
> way of handling this sort of thing in C code? Is it just a case of putting
> some sort of SYMBOLP check in before the variable is used or should we
> be able to handle a string instead of a symbol?

This is not NS specific.  The following recipe will crash Emacs on any
platform:

  (let ((where-is-preferred-modifier "alt"))
    (where-is 'goto-char))

I think I've fixed this on the master branch, by outright rejecting
non-symbol values of modifiers in parse_solitary_modifier.  I don't
think supporting strings there is required, as this clearly is a
cockpit error.

Thanks.