unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: randy@psg.com, emacs-devel@gnu.org
Subject: Re: Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke
Date: Mon, 29 Aug 2016 19:37:45 +0100	[thread overview]
Message-ID: <20160829183745.GA68214@breton.holly.idiocy.org> (raw)
In-Reply-To: <83poorbq8b.fsf@gnu.org>

On Mon, Aug 29, 2016 at 05:32:20PM +0300, Eli Zaretskii wrote:
> This is not NS specific.  The following recipe will crash Emacs on any
> platform:
> 
>   (let ((where-is-preferred-modifier "alt"))
>     (where-is 'goto-char))
> 
> I think I've fixed this on the master branch, by outright rejecting
> non-symbol values of modifiers in parse_solitary_modifier.  I don't
> think supporting strings there is required, as this clearly is a
> cockpit error.

Thanks Eli. You’ve fixed the crash here.
-- 
Alan Third



  reply	other threads:[~2016-08-29 18:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  9:04 Emacs-24.5-1-universal.dmg for macosx dumps on first keystroke Randy Bush
2016-08-25 15:08 ` Alan Third
2016-08-25 19:10   ` Randy Bush
2016-08-25 22:38     ` Alan Third
2016-08-26  0:32       ` Randy Bush
2016-08-26  3:11       ` Randy Bush
2016-08-26 18:21         ` Alan Third
2016-08-26 19:26           ` Robert Weiner
2016-08-29  9:28           ` Alan Third
2016-08-29  9:31             ` Randy Bush
2016-08-29  9:37             ` Anders Lindgren
2016-08-29 13:19             ` Stefan Monnier
2016-08-29 14:32             ` Eli Zaretskii
2016-08-29 18:37               ` Alan Third [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-08-25 10:04 Randy Bush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160829183745.GA68214@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=randy@psg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).