From: Juri Linkov <juri@jurta.org>
Cc: public@heslin.eclipse.co.uk, mange@freemail.hu,
S.J.Eglen@damtp.cam.ac.uk
Subject: Re: flyspell bug
Date: Tue, 10 May 2005 03:06:48 +0300 [thread overview]
Message-ID: <87zmv3rg09.fsf_-_@jurta.org> (raw)
In-Reply-To: <01c5531e$Blat.v2.4$ea8d9a00@zahav.net.il> (Eli Zaretskii's message of "Sat, 07 May 2005 19:06:47 +0300")
>> To: emacs-devel@gnu.org
>> From: Magnus Henoch <mange@freemail.hu>
>> Date: Wed, 27 Apr 2005 16:04:45 +0200
>> Subject: Re: flyspell bug
>>
>> So it seems that the variable ispell-really-aspell is moderately
>> useful, as there are three situations: ispell, aspell in ispell
>> compatibility mode, and "real" aspell.
>>
>> The following patch eliminates the middle case. The documentation of
>> aspell 0.50.5 claims that it supports the "list" command, but I
>> haven't tested it.
>>
>> - --- orig/lisp/textmodes/ispell.el
>> +++ mod/lisp/textmodes/ispell.el
>> @@ -301,7 +301,8 @@
>> :type 'integer
>> :group 'ispell)
>>
>> - -(defcustom ispell-program-name "ispell"
>> +(defcustom ispell-program-name (or (executable-find "aspell")
>> + "ispell")
>> "Program invoked by \\[ispell-word] and \\[ispell-region] commands."
>> :type 'string
>> :group 'ispell)
>
> Thanks, I installed a slightly different change (using locate-file
> instead of executable-find).
Now with using a non-default dictionary ispell.el fails with the
error message telling that ispell can't find a dictionary in
/usr/lib/aspell-0.60/. That's becuase ispell and aspell have
different sets of dictionaries with different names.
ispell.el shouldn't insist on using "aspell" instead of "ispell"
even when aspell executable happens to be in exec-path.
Perhaps the following patch will do what was intended to fix the
original problem:
Index: lisp/textmodes/ispell.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/textmodes/ispell.el,v
retrieving revision 1.162
diff -u -r1.162 ispell.el
--- lisp/textmodes/ispell.el 7 May 2005 16:04:39 -0000 1.162
+++ lisp/textmodes/ispell.el 10 May 2005 00:05:05 -0000
@@ -302,7 +302,8 @@
:group 'ispell)
(defcustom ispell-program-name
- (or (locate-file "aspell" exec-path exec-suffixes 'file-executable-p)
+ (or (and ispell-really-aspell
+ (locate-file "aspell" exec-path exec-suffixes 'file-executable-p))
"ispell")
"Program invoked by \\[ispell-word] and \\[ispell-region] commands."
:type 'string
@@ -815,7 +816,11 @@
(goto-char (point-min))
(let (case-fold-search)
(setq ispell-really-aspell
- (and (search-forward "(but really Aspell " nil t) t))))
+ (and (search-forward "(but really Aspell " nil t) t))
+ (if ispell-really-aspell
+ (let ((exec (locate-file "aspell" exec-path exec-suffixes
+ 'file-executable-p)))
+ (if exec (setq ispell-program-name exec))))))
(kill-buffer (current-buffer)))
result))
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2005-05-10 0:06 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1DR6lU-0005vs-O1@fencepost.gnu.org>
2005-05-07 16:06 ` [mange@freemail.hu: Re: flyspell bug] Eli Zaretskii
2005-05-10 0:06 ` Juri Linkov [this message]
2005-05-10 3:37 ` flyspell bug Eli Zaretskii
2005-05-10 5:04 ` Juri Linkov
2005-05-10 19:46 ` Eli Zaretskii
2005-05-11 8:23 ` Juri Linkov
2005-05-11 12:40 ` Eli Zaretskii
2005-05-12 5:29 ` Juri Linkov
2005-05-12 6:55 ` Eli Zaretskii
2005-05-12 6:14 ` Juri Linkov
2005-05-12 9:09 ` Eli Zaretskii
2005-05-12 17:13 ` Ken Stevens
2005-05-13 16:09 ` Richard Stallman
2005-05-13 20:09 ` Ken Stevens
2005-05-14 4:07 ` Richard Stallman
2005-05-13 1:34 ` Richard Stallman
2005-05-12 8:30 ` Richard Stallman
2005-05-23 14:51 ` Kevin Atkinson
2005-05-25 1:18 ` Richard Stallman
2005-05-25 15:50 ` Kevin Atkinson
2005-05-26 6:00 ` Richard Stallman
2005-05-25 16:48 ` Juri Linkov
2005-05-25 18:11 ` Kevin Atkinson
2005-05-26 6:00 ` Richard Stallman
2005-05-11 16:29 ` Richard Stallman
2005-05-12 5:28 ` Juri Linkov
2005-05-13 1:34 ` Richard Stallman
2005-10-02 17:08 Richard M. Stallman
2005-10-02 20:10 ` Slawomir Nowaczyk
2005-10-02 21:45 ` Kim F. Storm
2005-10-02 23:28 ` Slawomir Nowaczyk
2005-10-03 15:34 ` Richard M. Stallman
2005-10-03 16:14 ` Kim F. Storm
2005-10-03 19:31 ` Richard M. Stallman
2005-10-04 8:58 ` Kim F. Storm
2005-10-05 3:32 ` Richard M. Stallman
2005-10-05 8:34 ` David Kastrup
2005-10-03 15:35 ` Richard M. Stallman
2005-10-05 10:41 ` Slawomir Nowaczyk
2005-10-05 13:16 ` Slawomir Nowaczyk
2005-10-10 4:15 ` Richard M. Stallman
2005-10-12 8:43 ` Slawomir Nowaczyk
2005-10-13 4:52 ` Richard M. Stallman
2005-10-13 10:40 ` Slawomir Nowaczyk
2005-10-14 5:11 ` Richard M. Stallman
2005-10-14 11:59 ` Slawomir Nowaczyk
2005-10-23 4:42 ` Richard M. Stallman
2005-10-23 11:50 ` Piet van Oostrum
2005-10-24 1:00 ` Richard M. Stallman
2005-10-24 7:16 ` Piet van Oostrum
2005-10-24 13:39 ` Piet van Oostrum
2005-10-24 14:49 ` Piet van Oostrum
2005-10-24 23:22 ` Slawomir Nowaczyk
2005-10-25 13:40 ` Agustin Martin
2005-10-25 15:59 ` Richard M. Stallman
2005-11-18 15:54 ` Agustin Martin
2005-11-19 23:26 ` Richard M. Stallman
2005-11-20 20:36 ` Agustin Martin
2005-11-21 8:10 ` Richard M. Stallman
2005-10-24 16:27 ` Richard M. Stallman
2005-10-24 17:51 ` Piet van Oostrum
2005-10-24 23:22 ` Slawomir Nowaczyk
2005-10-26 16:46 ` Richard M. Stallman
2005-10-27 17:20 ` Slawomir Nowaczyk
2005-10-28 16:19 ` Richard M. Stallman
2005-10-28 13:32 ` Agustin Martin
2005-10-28 21:57 ` Piet van Oostrum
2005-10-29 0:18 ` Slawomir Nowaczyk
2005-10-29 20:33 ` Richard M. Stallman
2005-10-31 14:50 ` Slawomir Nowaczyk
2005-11-01 10:19 ` Piet van Oostrum
2005-11-02 10:18 ` Slawomir Nowaczyk
2005-11-02 21:30 ` Piet van Oostrum
2005-11-03 14:35 ` Slawomir Nowaczyk
2005-11-04 9:20 ` Piet van Oostrum
2005-11-04 12:27 ` Agustin Martin
2005-11-04 14:04 ` Slawomir Nowaczyk
2005-11-04 17:41 ` Agustin Martin
2005-11-05 1:37 ` Richard M. Stallman
2005-11-02 10:27 ` Richard M. Stallman
2005-11-07 15:35 ` Richard M. Stallman
2005-11-07 15:51 ` Slawomir Nowaczyk
2005-11-16 15:22 ` Agustin Martin
2005-11-18 14:51 ` Agustin Martin
2005-10-29 5:13 ` Richard M. Stallman
2005-10-29 10:12 ` Piet van Oostrum
2005-10-29 12:11 ` David Kastrup
2005-10-29 19:51 ` Piet van Oostrum
2005-10-29 20:34 ` Richard M. Stallman
2005-10-30 13:25 ` Piet van Oostrum
2005-10-31 1:14 ` Richard M. Stallman
2005-10-30 1:14 ` Agustin Martin
2005-10-30 12:23 ` Piet van Oostrum
2005-10-28 11:11 ` Agustin Martin
-- strict thread matches above, loose matches on Subject: below --
2005-04-25 11:30 Stephen Eglen
2005-04-26 1:28 ` Peter Heslin
2005-04-26 8:30 ` Stephen Eglen
2005-04-26 22:55 ` Richard Stallman
2005-04-27 9:13 ` Stephen Eglen
2005-04-27 14:04 ` Magnus Henoch
2005-04-27 16:01 ` Stephen Eglen
2005-05-10 10:40 ` Kai Großjohann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmv3rg09.fsf_-_@jurta.org \
--to=juri@jurta.org \
--cc=S.J.Eglen@damtp.cam.ac.uk \
--cc=mange@freemail.hu \
--cc=public@heslin.eclipse.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).