From: Slawomir Nowaczyk <slawomir.nowaczyk.847@student.lu.se>
Subject: Re: flyspell bug
Date: Mon, 07 Nov 2005 16:51:22 +0100 [thread overview]
Message-ID: <20051107165012.074E.SLAWOMIR.NOWACZYK.847@student.lu.se> (raw)
In-Reply-To: <20051031164057.1F82.SLAWOMIR.NOWACZYK.847@student.lu.se>
OK, I finally had some time (not enough, though) to debug the problem,
and here is what I have found.
First of all, there is problem with flyspell-buffer not taking into
account the LocalWords: definition (the list of words assumed to be
correct in particular buffer). Words from this list are reported in
flyspell-external-ispell-buffer by ispell, but are not considered to
be misspelled by flyspell-word. This causes the logic in
flyspell-external-point-words to get out of sync with the buffer
contents.
I do not know how to fix this, though. There is
ispell-buffer-local-words in ispell.el, but I do not know enough about
ispell to understand what it is doing, or even if this is a right
place to start.
As an ugly kludge, the following patch does seem to fix things for me:
*** M:\EmacsCVS\EmacsCVS\lisp\textmodes\flyspell.el Mon Nov 7 15:00:13 2005
--- c:\Emacs\lisp\textmodes\flyspell.el Mon Nov 7 16:39:45 2005
***************
*** 1365,1371 ****
(if (< (length (car (flyspell-get-word nil)))
(length word))
nil
! (flyspell-word))))
(error "Bug: misspelled word `%s' (output pos %d) not found in buffer"
word wordpos)))))))
;; we are done
--- 1365,1374 ----
(if (< (length (car (flyspell-get-word nil)))
(length word))
nil
! (if (= (length (car (flyspell-get-word nil)))
! (length word))
! (and (flyspell-word) nil) ;; flyspell-word but exit the loop unconditionally
! (flyspell-word)))))
(error "Bug: misspelled word `%s' (output pos %d) not found in buffer"
word wordpos)))))))
;; we are done
***************
But I would prefer to have LocalWords taken care of by ispell -- if
only due to the fact that it should make flyspell-buffer significantly
faster.
Besides that, I believe the logic in flyspell-external-point-words
should be simplified significantly -- we should get rid of the "while
keep" loop, just find the first place where
(if (= (length (flyspell-get-word nil))
(length word))
and flyspell-word that. And consider cases where ispell and flyspell
have different ideas about word boundaries to be bugs and fix those.
--
Best wishes,
Slawomir Nowaczyk
( slawomir.nowaczyk.847@student.lu.se )
A computer DOES save time at work. I can play solitaire without
having to spend all that time shuffling real cards.
next prev parent reply other threads:[~2005-11-07 15:51 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-02 17:08 flyspell bug Richard M. Stallman
2005-10-02 20:10 ` Slawomir Nowaczyk
2005-10-02 21:45 ` Kim F. Storm
2005-10-02 23:28 ` Slawomir Nowaczyk
2005-10-03 15:34 ` Richard M. Stallman
2005-10-03 16:14 ` Kim F. Storm
2005-10-03 19:31 ` Richard M. Stallman
2005-10-04 8:58 ` Kim F. Storm
2005-10-05 3:32 ` Richard M. Stallman
2005-10-05 8:34 ` David Kastrup
2005-10-03 15:35 ` Richard M. Stallman
2005-10-05 10:41 ` Slawomir Nowaczyk
2005-10-05 13:16 ` Slawomir Nowaczyk
2005-10-10 4:15 ` Richard M. Stallman
2005-10-12 8:43 ` Slawomir Nowaczyk
2005-10-13 4:52 ` Richard M. Stallman
2005-10-13 10:40 ` Slawomir Nowaczyk
2005-10-14 5:11 ` Richard M. Stallman
2005-10-14 11:59 ` Slawomir Nowaczyk
2005-10-23 4:42 ` Richard M. Stallman
2005-10-23 11:50 ` Piet van Oostrum
2005-10-24 1:00 ` Richard M. Stallman
2005-10-24 7:16 ` Piet van Oostrum
2005-10-24 13:39 ` Piet van Oostrum
2005-10-24 14:49 ` Piet van Oostrum
2005-10-24 23:22 ` Slawomir Nowaczyk
2005-10-25 13:40 ` Agustin Martin
2005-10-25 15:59 ` Richard M. Stallman
2005-11-18 15:54 ` Agustin Martin
2005-11-19 23:26 ` Richard M. Stallman
2005-11-20 20:36 ` Agustin Martin
2005-11-21 8:10 ` Richard M. Stallman
2005-10-24 16:27 ` Richard M. Stallman
2005-10-24 17:51 ` Piet van Oostrum
2005-10-24 23:22 ` Slawomir Nowaczyk
2005-10-26 16:46 ` Richard M. Stallman
2005-10-27 17:20 ` Slawomir Nowaczyk
2005-10-28 16:19 ` Richard M. Stallman
2005-10-28 13:32 ` Agustin Martin
2005-10-28 21:57 ` Piet van Oostrum
2005-10-29 0:18 ` Slawomir Nowaczyk
2005-10-29 20:33 ` Richard M. Stallman
2005-10-31 14:50 ` Slawomir Nowaczyk
2005-11-01 10:19 ` Piet van Oostrum
2005-11-02 10:18 ` Slawomir Nowaczyk
2005-11-02 21:30 ` Piet van Oostrum
2005-11-03 14:35 ` Slawomir Nowaczyk
2005-11-04 9:20 ` Piet van Oostrum
2005-11-04 12:27 ` Agustin Martin
2005-11-04 14:04 ` Slawomir Nowaczyk
2005-11-04 17:41 ` Agustin Martin
2005-11-05 1:37 ` Richard M. Stallman
2005-11-02 10:27 ` Richard M. Stallman
2005-11-07 15:35 ` Richard M. Stallman
2005-11-07 15:51 ` Slawomir Nowaczyk [this message]
2005-11-16 15:22 ` Agustin Martin
2005-11-18 14:51 ` Agustin Martin
2005-11-23 10:19 ` flyspell bug [possible patch] Agustin Martin
2005-11-24 3:58 ` Richard M. Stallman
2005-11-24 14:53 ` Agustin Martin
2005-10-29 5:13 ` flyspell bug Richard M. Stallman
2005-10-29 10:12 ` Piet van Oostrum
2005-10-29 12:11 ` David Kastrup
2005-10-29 19:51 ` Piet van Oostrum
2005-10-29 20:34 ` Richard M. Stallman
2005-10-30 13:25 ` Piet van Oostrum
2005-10-31 1:14 ` Richard M. Stallman
2005-10-30 1:14 ` Agustin Martin
2005-10-30 12:23 ` Piet van Oostrum
2005-10-28 11:11 ` Agustin Martin
[not found] <E1DR6lU-0005vs-O1@fencepost.gnu.org>
2005-05-07 16:06 ` [mange@freemail.hu: Re: flyspell bug] Eli Zaretskii
2005-05-10 0:06 ` flyspell bug Juri Linkov
2005-05-10 3:37 ` Eli Zaretskii
2005-05-10 5:04 ` Juri Linkov
2005-05-10 19:46 ` Eli Zaretskii
2005-05-11 8:23 ` Juri Linkov
2005-05-11 12:40 ` Eli Zaretskii
2005-05-12 5:29 ` Juri Linkov
2005-05-12 6:55 ` Eli Zaretskii
2005-05-12 6:14 ` Juri Linkov
2005-05-12 9:09 ` Eli Zaretskii
2005-05-12 17:13 ` Ken Stevens
2005-05-13 16:09 ` Richard Stallman
2005-05-13 20:09 ` Ken Stevens
2005-05-14 4:07 ` Richard Stallman
2005-05-13 1:34 ` Richard Stallman
2005-05-12 8:30 ` Richard Stallman
2005-05-23 14:51 ` Kevin Atkinson
2005-05-25 1:18 ` Richard Stallman
2005-05-25 15:50 ` Kevin Atkinson
2005-05-26 6:00 ` Richard Stallman
2005-05-25 16:48 ` Juri Linkov
2005-05-25 18:11 ` Kevin Atkinson
2005-05-26 6:00 ` Richard Stallman
2005-05-11 16:29 ` Richard Stallman
2005-05-12 5:28 ` Juri Linkov
2005-05-13 1:34 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2005-04-25 11:30 Stephen Eglen
2005-04-26 1:28 ` Peter Heslin
2005-04-26 8:30 ` Stephen Eglen
2005-04-26 22:55 ` Richard Stallman
2005-04-27 9:13 ` Stephen Eglen
2005-04-27 14:04 ` Magnus Henoch
2005-04-27 16:01 ` Stephen Eglen
2005-05-10 10:40 ` Kai Großjohann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107165012.074E.SLAWOMIR.NOWACZYK.847@student.lu.se \
--to=slawomir.nowaczyk.847@student.lu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).