From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: felician.nemeth@gmail.com, emacs-devel@gnu.org
Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot
Date: Fri, 05 May 2023 17:41:58 +0100 [thread overview]
Message-ID: <87y1m2spbd.fsf@gmail.com> (raw)
In-Reply-To: <835y96j10l.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 May 2023 17:39:22 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> I understand and agree in general, but surely each change should be
> judged by itself, and some, maybe many, might not have these
> problematic aspects?
Right. Each change can be judged by itself.
>> A guiding principle of eglot.el (and indede LSP) is to not have any
>> server-specific code.
>
> If "server-specific" behavior is, for example, just some non-standard
> capabilities, that doesn't count as "server-specific code" in my book.
> After all, a standard-compliant server could very well implement only
> a subset of the capabilities documented by the standard.
Right, again. Each change should be judged on its own merits.
> But it should not use advice, IMNSHO.
Agree.
next prev parent reply other threads:[~2023-05-05 16:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 11:56 [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Felician Nemeth
2023-05-05 13:18 ` Ruijie Yu via Emacs development discussions.
2023-05-06 13:14 ` Felician Nemeth
2023-05-05 13:26 ` Eli Zaretskii
2023-05-05 14:20 ` João Távora
2023-05-05 14:39 ` Eli Zaretskii
2023-05-05 16:41 ` João Távora [this message]
2023-05-06 13:12 ` Felician Nemeth
2023-05-06 13:27 ` Eli Zaretskii
2023-05-06 15:17 ` Felician Nemeth
2023-05-06 15:27 ` Eli Zaretskii
2023-05-06 13:51 ` João Távora
2023-05-06 15:28 ` Felician Nemeth
2023-05-05 16:38 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1m2spbd.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=felician.nemeth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).