unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: emacs-devel@gnu.org, joaotavora@gmail.com
Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot
Date: Fri, 05 May 2023 16:26:18 +0300	[thread overview]
Message-ID: <83h6sqj4ed.fsf@gnu.org> (raw)
In-Reply-To: <874jorc7q2.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Fri, 05 May 2023 13:56:21 +0200)

> From: Felician Nemeth <felician.nemeth@gmail.com>
> Cc: João Távora <joaotavora@gmail.com>
> Date: Fri, 05 May 2023 13:56:21 +0200
> 
> I'd like to submit a new package called eglot-x to ELPA.  Its commentary
> starts with:
> 
> ;; Eglot supports (a subset of) the Language Server Protocol.  However,
> ;; there are useful protocol extensions that are not part of the
> ;; official protocol specification.  Eglot-x adds support for some of
> ;; them.  If you find a bug in Eglot, please, try to reproduce it
> ;; without Eglot-x, because Eglot-x is substantially modifies Eglot's
> ;; normal behavior as well.
> 
> João intend to support only the standardized protocol features in
> eglot.el, but lots of LSP servers extend the protocol in their own way.
> (It was João who suggested the package name long ago.)  I considered
> eglot-x just an experiment and a learning possibility, but people seem
> to use it, so I'd like to make their life easier by this submission.

It sounds strange to me to refuse to support LSP extensions in
eglot.el.  At the very least, eglot.el could benefit from offering a
supported mechanism for adding such extensions; there should be no
need for using advice for that.

João, why would you not consider supporting these extensions as part
of eglot.el?



  parent reply	other threads:[~2023-05-05 13:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 11:56 [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Felician Nemeth
2023-05-05 13:18 ` Ruijie Yu via Emacs development discussions.
2023-05-06 13:14   ` Felician Nemeth
2023-05-05 13:26 ` Eli Zaretskii [this message]
2023-05-05 14:20   ` João Távora
2023-05-05 14:39     ` Eli Zaretskii
2023-05-05 16:41       ` João Távora
2023-05-06 13:12         ` Felician Nemeth
2023-05-06 13:27           ` Eli Zaretskii
2023-05-06 15:17             ` Felician Nemeth
2023-05-06 15:27               ` Eli Zaretskii
2023-05-06 13:51           ` João Távora
2023-05-06 15:28             ` Felician Nemeth
2023-05-05 16:38   ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6sqj4ed.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=felician.nemeth@gmail.com \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).