From: Felician Nemeth <felician.nemeth@gmail.com>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel@gnu.org
Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot
Date: Sat, 06 May 2023 15:14:52 +0200 [thread overview]
Message-ID: <87lei1bnzn.fsf@betli.tmit.bme.hu> (raw)
In-Reply-To: <sdv354agbac.fsf@netyu.xyz> (Ruijie Yu's message of "Fri, 05 May 2023 21:18:23 +0800")
Thanks for your comments. I'll update the README based on this
feedback.
Ruijie Yu <ruijie@netyu.xyz> writes:
> Didn't look into its sources, but the idea definitely sounds good. Some
> in-line comments below regarding the commentary you attached.
>
> Felician Nemeth <felician.nemeth@gmail.com> writes:
>
>> I'd like to submit a new package called eglot-x to ELPA. Its commentary
>> starts with:
>>
>> ;; Eglot supports (a subset of) the Language Server Protocol. However,
>
> I think you should mention (as you did down below) that eglot only
> supports standardized protocol features of the LSP, in particular,
> _nothing more_ -- hence your package to support commonly-used, yet not
> standardized protocol specs. Thoughts?
>
>> ;; there are useful protocol extensions that are not part of the
>> ;; official protocol specification. Eglot-x adds support for some of
>> ;; them. If you find a bug in Eglot, please, try to reproduce it
>
> New paragraph here at "if"?
>
>> ;; without Eglot-x, because Eglot-x is substantially modifies Eglot's
>
> Syntax: change "is substantially modifies" into either "substantially
> modifies" or "has substantially modified".
>
>> ;; normal behavior as well.
>>
>> João intend to support only the standardized protocol features in
>> eglot.el, but lots of LSP servers extend the protocol in their own way.
>> (It was João who suggested the package name long ago.) I considered
>> eglot-x just an experiment and a learning possibility, but people seem
>> to use it, so I'd like to make their life easier by this submission.
>>
>> Currently, it mainly implements extensions for rust-analyzer and taplo,
>> but some other extensions are supported as well.
>>
>> The package is hosted at https://github.com/nemethf/eglot-x
>>
>> Thanks,
>> Felicián
next prev parent reply other threads:[~2023-05-06 13:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 11:56 [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Felician Nemeth
2023-05-05 13:18 ` Ruijie Yu via Emacs development discussions.
2023-05-06 13:14 ` Felician Nemeth [this message]
2023-05-05 13:26 ` Eli Zaretskii
2023-05-05 14:20 ` João Távora
2023-05-05 14:39 ` Eli Zaretskii
2023-05-05 16:41 ` João Távora
2023-05-06 13:12 ` Felician Nemeth
2023-05-06 13:27 ` Eli Zaretskii
2023-05-06 15:17 ` Felician Nemeth
2023-05-06 15:27 ` Eli Zaretskii
2023-05-06 13:51 ` João Távora
2023-05-06 15:28 ` Felician Nemeth
2023-05-05 16:38 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lei1bnzn.fsf@betli.tmit.bme.hu \
--to=felician.nemeth@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).