From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: bugfix eshell/rm
Date: Sat, 12 Mar 2011 09:30:14 +0100 [thread overview]
Message-ID: <87wrk4eo6h.fsf@gmail.com> (raw)
In-Reply-To: <gewrk62htd.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 11 Mar 2011 03:16:14 -0500")
Glenn Morris <rgm@gnu.org> writes:
> Thierry Volpiatto wrote:
>
>> `eshell-remove-entries' use a not bound 'verbose' variable, and fail.
>
> It's dynamically bound in eshell/rm via eshell-eval-using-options.
>
>> To reproduce bug, try "rm -rf /some/directory" in eshell.
>
> Works fine for me.
Sorry to insist, but something is wrong here.
On emacs-23.3, if you turn on `delete-by-moving-to-trash',
rm -rf hang forever.
This is because in `eshell-remove-entries', `delete-directory' and
`delete-file' take respectively 3 and 2 arguments.
This is correct for emacs24 but not for emacs23.
Use a consequent directory to test, i.e not a too small directory.
So of course in emacs24 this is working fine.
Maybe some changes in em-unix.el for emacs24 have been merged in
emacs-23 branch without appropriate modifications?
--
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2011-03-12 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 8:04 bugfix eshell/rm Thierry Volpiatto
2011-03-11 8:16 ` Glenn Morris
2011-03-11 9:08 ` Thierry Volpiatto
2011-03-11 10:18 ` Eli Zaretskii
2011-03-11 12:17 ` Thierry Volpiatto
2011-03-11 12:23 ` Eli Zaretskii
2011-03-11 12:50 ` Thierry Volpiatto
2011-03-11 15:59 ` Eli Zaretskii
2011-03-11 18:03 ` Thierry Volpiatto
2011-03-12 18:39 ` Glenn Morris
2011-03-12 20:12 ` bug and dev mailing lists [was: bugfix eshell/rm] Drew Adams
2011-03-12 20:25 ` Eli Zaretskii
2011-03-12 22:43 ` Drew Adams
2011-03-12 8:30 ` Thierry Volpiatto [this message]
2011-03-12 8:45 ` bugfix eshell/rm Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrk4eo6h.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).