unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: emacs-devel@gnu.org
Subject: bugfix eshell/rm
Date: Fri, 11 Mar 2011 09:04:07 +0100	[thread overview]
Message-ID: <8762rqozgo.fsf@gmail.com> (raw)

Hi all,
`eshell-remove-entries' use a not bound 'verbose' variable, and fail.
To reproduce bug, try "rm -rf /some/directory" in eshell.
 

This patch fix it.
however there is maybe other calls to `eshell-remove-entries' to fix.

This is on emacs-23.3

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/eshell/em-unix.el b/lisp/eshell/em-unix.el
index 8f61270..0a79e80 100644
--- a/lisp/eshell/em-unix.el
+++ b/lisp/eshell/em-unix.el
@@ -194,7 +194,7 @@ Otherwise, Emacs will attempt to use rsh to invoke du on the remote machine."
       (Info-menu (car args))
       (setq args (cdr args)))))
 
-(defun eshell-remove-entries (path files &optional top-level)
+(defun eshell-remove-entries (path files &optional top-level verbose)
   "From PATH, remove all of the given FILES, perhaps interactively."
   (while files
     (if (string-match "\\`\\.\\.?\\'"
@@ -298,7 +298,7 @@ Remove (unlink) the FILE(s).")
 			 (y-or-n-p
 			  (format "rm: descend into directory `%s'? "
 				  entry)))
-		     (eshell-remove-entries nil (list entry) t))
+		     (eshell-remove-entries nil (list entry) t nil))
 	       (eshell-error (format "rm: %s: is a directory\n" entry)))
 	   (eshell-remove-entries nil (list entry) t)))))
      (setq args (cdr args)))
--8<---------------cut here---------------end--------------->8---

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 




             reply	other threads:[~2011-03-11  8:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  8:04 Thierry Volpiatto [this message]
2011-03-11  8:16 ` bugfix eshell/rm Glenn Morris
2011-03-11  9:08   ` Thierry Volpiatto
2011-03-11 10:18     ` Eli Zaretskii
2011-03-11 12:17       ` Thierry Volpiatto
2011-03-11 12:23         ` Eli Zaretskii
2011-03-11 12:50           ` Thierry Volpiatto
2011-03-11 15:59             ` Eli Zaretskii
2011-03-11 18:03               ` Thierry Volpiatto
2011-03-12 18:39     ` Glenn Morris
2011-03-12 20:12       ` bug and dev mailing lists [was: bugfix eshell/rm] Drew Adams
2011-03-12 20:25         ` Eli Zaretskii
2011-03-12 22:43           ` Drew Adams
2011-03-12  8:30   ` bugfix eshell/rm Thierry Volpiatto
2011-03-12  8:45     ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762rqozgo.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).