Re: bugfix eshell/rm

[Thierry Volpiatto <thierry.volpiatto@gmail.com>]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Thierry Volpiatto wrote:
>>
>>> `eshell-remove-entries' use a not bound 'verbose' variable, and fail.
>>
>> It's dynamically bound in eshell/rm via eshell-eval-using-options.
>>
>>> To reproduce bug, try "rm -rf /some/directory" in eshell.
>>
>> Works fine for me.
> Sorry to insist, but something is wrong here.
> On emacs-23.3, if you turn on `delete-by-moving-to-trash',
> rm -rf hang forever.
> This is because in `eshell-remove-entries', `delete-directory' and
> `delete-file' take respectively 3 and 2 arguments.
> This is correct for emacs24 but not for emacs23.
>
> Use a consequent directory to test, i.e not a too small directory.
>
> So of course in emacs24 this is working fine.
>
> Maybe some changes in em-unix.el for emacs24 have been merged in
> emacs-23 branch without appropriate modifications?

So now back in emacs23, if i remove the 3 and 2 arguments to
delete-directory and delete-file, reeval eshell-remove-entries and
eshell/rm, all work fine.

--8<---------------cut here---------------start------------->8---
(eshell-funcalln 'delete-directory (car files) t t)
                                                 ^ removed
(eshell-funcalln 'delete-file (car files) t)
                                          ^ removed
--8<---------------cut here---------------end--------------->8---

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997