From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bugfix eshell/rm Date: Sat, 12 Mar 2011 09:30:14 +0100 Message-ID: <87wrk4eo6h.fsf@gmail.com> References: <8762rqozgo.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1299918645 9965 80.91.229.12 (12 Mar 2011 08:30:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2011 08:30:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 09:30:35 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PyKDZ-0006MN-JP for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2011 09:30:34 +0100 Original-Received: from localhost ([127.0.0.1]:40159 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyKDX-0002iM-Ky for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2011 03:30:31 -0500 Original-Received: from [140.186.70.92] (port=47393 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyKDN-0002ew-Ld for emacs-devel@gnu.org; Sat, 12 Mar 2011 03:30:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PyKDL-0001cp-SG for emacs-devel@gnu.org; Sat, 12 Mar 2011 03:30:20 -0500 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:61975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PyKDL-0001cZ-Ki; Sat, 12 Mar 2011 03:30:19 -0500 Original-Received: by wwi17 with SMTP id 17so260674wwi.0 for ; Sat, 12 Mar 2011 00:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=SDIvnPNL7TxRWPYmqeDD8ZAJHva71XItz34smIVaV/g=; b=V9qaMCVX7OvQElcFTEAoJ22jK3qhE3VCNesruUumIv8vvPwZEX6g79d8PMR5ohWO+Z fKbomVluo2s7GL3Cn2TqzQVNAojNQ8uU82luOmRTeST+mytYPJo91hDfCFgxBMbDMVlt m5kPZWOngEa/fIdlvUk9bvvg6h5mChYr4tFYc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=a8NN0ALDDardIs6PhoKo0AEKaS/8mh0Nhp4OMpMViDjMGF4QFV8c8QBwWm42FolebT akq9qHtwjlQdPd2FE5QZOAx+H+1Y0RMZPlHez4Hmv+gDwXPC2FjVUHc3es3zGLF2yyr1 YFWs1WPf4WQfYrY3BDPRzR9Tn04m0PLND7yH4= Original-Received: by 10.227.179.69 with SMTP id bp5mr2994806wbb.192.1299918618397; Sat, 12 Mar 2011 00:30:18 -0800 (PST) Original-Received: from thierry-MM061 (244.211.85-79.rev.gaoland.net [79.85.211.244]) by mx.google.com with ESMTPS id bd8sm4149128wbb.7.2011.03.12.00.30.15 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 12 Mar 2011 00:30:16 -0800 (PST) In-Reply-To: (Glenn Morris's message of "Fri, 11 Mar 2011 03:16:14 -0500") User-Agent: Gnus/5.110014 (No Gnus v0.14) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137139 Archived-At: Glenn Morris writes: > Thierry Volpiatto wrote: > >> `eshell-remove-entries' use a not bound 'verbose' variable, and fail. > > It's dynamically bound in eshell/rm via eshell-eval-using-options. > >> To reproduce bug, try "rm -rf /some/directory" in eshell. > > Works fine for me. Sorry to insist, but something is wrong here. On emacs-23.3, if you turn on `delete-by-moving-to-trash', rm -rf hang forever. This is because in `eshell-remove-entries', `delete-directory' and `delete-file' take respectively 3 and 2 arguments. This is correct for emacs24 but not for emacs23. Use a consequent directory to test, i.e not a too small directory. So of course in emacs24 this is working fine. Maybe some changes in em-unix.el for emacs24 have been merged in emacs-23 branch without appropriate modifications? -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997