* Re: master ad2d50d762: Fix last change in xterm.c
[not found] ` <20220213004114.975FDC00891@vcs2.savannah.gnu.org>
@ 2022-02-20 16:27 ` Lars Ingebrigtsen
2022-02-20 16:43 ` Eli Zaretskii
2022-02-21 0:45 ` Po Lu
0 siblings, 2 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-02-20 16:27 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
I have no idea whether it's this change that caused it or not, but:
xterm.c: In function ‘handle_one_xevent’:
xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
10125 | for (i = 0; i < nbytes; i++)
| ^~~
keyboard.c: In function ‘read_event_from_main_queue’:
keyboard.c:2251:22: warning: ‘kb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
2251 | current_kboard = kb;
| ~~~~~~~~~~~~~~~^~~~
I get these warnings when compiling now with nativecomp, and I don't
think they were there a couple of days ago? But I may be mistaken.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: master ad2d50d762: Fix last change in xterm.c
2022-02-20 16:27 ` master ad2d50d762: Fix last change in xterm.c Lars Ingebrigtsen
@ 2022-02-20 16:43 ` Eli Zaretskii
2022-02-20 17:13 ` Lars Ingebrigtsen
2022-02-21 0:45 ` Po Lu
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2022-02-20 16:43 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: luangruo, emacs-devel
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 20 Feb 2022 17:27:21 +0100
> Cc: Po Lu <luangruo@yahoo.com>
>
> I have no idea whether it's this change that caused it or not, but:
>
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
> 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
> 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
> 10125 | for (i = 0; i < nbytes; i++)
> | ^~~
> keyboard.c: In function ‘read_event_from_main_queue’:
> keyboard.c:2251:22: warning: ‘kb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 2251 | current_kboard = kb;
> | ~~~~~~~~~~~~~~~^~~~
>
> I get these warnings when compiling now with nativecomp, and I don't
> think they were there a couple of days ago? But I may be mistaken.
I've tried to fix these now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master ad2d50d762: Fix last change in xterm.c
2022-02-20 16:27 ` master ad2d50d762: Fix last change in xterm.c Lars Ingebrigtsen
2022-02-20 16:43 ` Eli Zaretskii
@ 2022-02-21 0:45 ` Po Lu
2022-02-21 8:39 ` Andreas Schwab
2022-02-21 14:07 ` Lars Ingebrigtsen
1 sibling, 2 replies; 6+ messages in thread
From: Po Lu @ 2022-02-21 0:45 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I have no idea whether it's this change that caused it or not, but:
>
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
> 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
> 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
> 10125 | for (i = 0; i < nbytes; i++)
>
> I get these warnings when compiling now with nativecomp, and I don't
> think they were there a couple of days ago? But I may be mistaken.
That's odd, since that code has been there forever. Do you get them
without nativecomp?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master ad2d50d762: Fix last change in xterm.c
2022-02-21 0:45 ` Po Lu
@ 2022-02-21 8:39 ` Andreas Schwab
2022-02-21 14:07 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2022-02-21 8:39 UTC (permalink / raw)
To: Po Lu; +Cc: Lars Ingebrigtsen, emacs-devel
On Feb 21 2022, Po Lu wrote:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I have no idea whether it's this change that caused it or not, but:
>>
>> xterm.c: In function ‘handle_one_xevent’:
>> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
>> 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
>> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
>> 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~
>> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
>> 10125 | for (i = 0; i < nbytes; i++)
>>
>> I get these warnings when compiling now with nativecomp, and I don't
>> think they were there a couple of days ago? But I may be mistaken.
>
> That's odd, since that code has been there forever.
That's not true, see commit 0a9c8855b0.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master ad2d50d762: Fix last change in xterm.c
2022-02-21 0:45 ` Po Lu
2022-02-21 8:39 ` Andreas Schwab
@ 2022-02-21 14:07 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-02-21 14:07 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> That's odd, since that code has been there forever. Do you get them
> without nativecomp?
No, only with nativecomp. (And Eli's pushed a fix for this already.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-21 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <164471287374.8915.7898836027190086271@vcs2.savannah.gnu.org>
[not found] ` <20220213004114.975FDC00891@vcs2.savannah.gnu.org>
2022-02-20 16:27 ` master ad2d50d762: Fix last change in xterm.c Lars Ingebrigtsen
2022-02-20 16:43 ` Eli Zaretskii
2022-02-20 17:13 ` Lars Ingebrigtsen
2022-02-21 0:45 ` Po Lu
2022-02-21 8:39 ` Andreas Schwab
2022-02-21 14:07 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).