From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master ad2d50d762: Fix last change in xterm.c Date: Sun, 20 Feb 2022 18:43:29 +0200 Message-ID: <83czjhwksu.fsf@gnu.org> References: <164471287374.8915.7898836027190086271@vcs2.savannah.gnu.org> <20220213004114.975FDC00891@vcs2.savannah.gnu.org> <87v8x9o652.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37442"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 20 17:45:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLpKc-0009Zl-Of for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Feb 2022 17:45:06 +0100 Original-Received: from localhost ([::1]:37142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLpKb-0003QY-9z for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Feb 2022 11:45:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLpJ3-0002Wl-L6 for emacs-devel@gnu.org; Sun, 20 Feb 2022 11:43:29 -0500 Original-Received: from [2001:470:142:3::e] (port=57992 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLpJ3-0007Br-AB; Sun, 20 Feb 2022 11:43:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jdbQb9I72uRFxEhDeO+jrUYjhNeOd9J+RiibcuFjiZY=; b=fVoSQYhB1YCDz7sPAFCA SzY+f9puE7+P9B/2307Aek2EKs7genHnaxSRGzSbayvmxMBiq4MtR8xCv0E+4sI9wKmWBb3ylu4rd i6dwPTXzMXfjwzYIJ+3ntRusuTR6reXHed65g3cpo6fA3jkGnSTi1jQ45ayIemFqVRVOQBK0bpneo vf/CDNWlx15jQwlY7dVm/cJixxko3SSFbmVjf5AUkJN1v/54pEmHbP4pu6FoGYQNVLyQQPQvByn6N 4rpRk3GAqgWAS/l/4GtMAxui56+ysnwzWZkkPX2TMfMotpKndSXuPBg0xDUeSR+6zwqgIri73wN00 KiIb8RydResZ4w==; Original-Received: from [87.69.77.57] (port=2556 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLpJ2-0006Mj-4W; Sun, 20 Feb 2022 11:43:28 -0500 In-Reply-To: <87v8x9o652.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 20 Feb 2022 17:27:21 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286523 Archived-At: > From: Lars Ingebrigtsen > Date: Sun, 20 Feb 2022 17:27:21 +0100 > Cc: Po Lu > > I have no idea whether it's this change that caused it or not, but: > > xterm.c: In function ‘handle_one_xevent’: > xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros] > 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~ > xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’ > 8880 | if (temp_index == ARRAYELTS (temp_buffer)) | ^~ > xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause > 10125 | for (i = 0; i < nbytes; i++) > | ^~~ > keyboard.c: In function ‘read_event_from_main_queue’: > keyboard.c:2251:22: warning: ‘kb’ may be used uninitialized in this function [-Wmaybe-uninitialized] > 2251 | current_kboard = kb; > | ~~~~~~~~~~~~~~~^~~~ > > I get these warnings when compiling now with nativecomp, and I don't > think they were there a couple of days ago? But I may be mistaken. I've tried to fix these now.