Re: master ad2d50d762: Fix last change in xterm.c

Re: master ad2d50d762: Fix last change in xterm.c

[Lars Ingebrigtsen]

I have no idea whether it's this change that caused it or not, but:

xterm.c: In function ‘handle_one_xevent’:
xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
 8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
 8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
10125 |             for (i = 0; i < nbytes; i++)
      |             ^~~
keyboard.c: In function ‘read_event_from_main_queue’:
keyboard.c:2251:22: warning: ‘kb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 2251 |       current_kboard = kb;
      |       ~~~~~~~~~~~~~~~^~~~

I get these warnings when compiling now with nativecomp, and I don't
think they were there a couple of days ago?  But I may be mistaken.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master ad2d50d762: Fix last change in xterm.c

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 20 Feb 2022 17:27:21 +0100
> Cc: Po Lu <luangruo@yahoo.com>
> 
> I have no idea whether it's this change that caused it or not, but:
> 
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
> 10125 |             for (i = 0; i < nbytes; i++)
>       |             ^~~
> keyboard.c: In function ‘read_event_from_main_queue’:
> keyboard.c:2251:22: warning: ‘kb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>  2251 |       current_kboard = kb;
>       |       ~~~~~~~~~~~~~~~^~~~
> 
> I get these warnings when compiling now with nativecomp, and I don't
> think they were there a couple of days ago?  But I may be mistaken.

I've tried to fix these now.

Re: master ad2d50d762: Fix last change in xterm.c

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I've tried to fix these now.

Thanks; the warnings are gone here now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master ad2d50d762: Fix last change in xterm.c

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I have no idea whether it's this change that caused it or not, but:
>
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
> 10125 |             for (i = 0; i < nbytes; i++)
>
> I get these warnings when compiling now with nativecomp, and I don't
> think they were there a couple of days ago?  But I may be mistaken.

That's odd, since that code has been there forever.  Do you get them
without nativecomp?

Thanks.

Re: master ad2d50d762: Fix last change in xterm.c

[Andreas Schwab]

On Feb 21 2022, Po Lu wrote:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I have no idea whether it's this change that caused it or not, but:
>>
>> xterm.c: In function ‘handle_one_xevent’:
>> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
>>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
>> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
>>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
>> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
>> 10125 |             for (i = 0; i < nbytes; i++)
>>
>> I get these warnings when compiling now with nativecomp, and I don't
>> think they were there a couple of days ago?  But I may be mistaken.
>
> That's odd, since that code has been there forever.

That's not true, see commit 0a9c8855b0.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: master ad2d50d762: Fix last change in xterm.c

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> That's odd, since that code has been there forever.  Do you get them
> without nativecomp?

No, only with nativecomp.  (And Eli's pushed a fix for this already.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no