From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Proposed changes to gnus-dup.el
Date: Mon, 25 Mar 2019 17:33:17 +0000 [thread overview]
Message-ID: <87r2aurh9e.fsf@tcd.ie> (raw)
In-Reply-To: <vz1lg13j67g.fsf@gmail.com> (Andy Moreton's message of "Mon, 25 Mar 2019 15:59:15 +0000")
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Mon 25 Mar 2019, Basil L. Contovounesios wrote:
>
>> While looking into bug#34973, bug#34974, and bug#34987, I accumulated
>> the attached changes to lisp/gnus/gnus-dup.el which I would like to push
>> to master. WDYT?
>
> Given the games Gnus plays with bindings (see `defvoo' and `deffoo') the
> switch to lexical binding for gnus may prove to be complex.
There are no such binding constructs in gnus-dup.el, and switching to
lexical-binding in this file was simple, as the patch demonstrates.
> It would be better to avoid switching to lexical binding for a single
> file in gnus: rather, do that as part of a larger effort to switch all
> of gnus over to lexical binding.
Why would that be better?
Enabling lexical-binding in a small, simple file carries little risk of
fallout while providing the (admittedly tiny) benefit of bringing us one
increment closer to lexical Gnus.
Sweeping changes across the whole Gnus system, OTOH, are far more risky,
as the recent switch to hash-tables has taught us.
I would welcome such a wholesale switch to lexical-binding, but I see no
reason or benefit to hold back on one file in the meantime.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-03-25 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 3:55 Proposed changes to gnus-dup.el Basil L. Contovounesios
2019-03-25 15:59 ` Andy Moreton
2019-03-25 16:50 ` Stefan Monnier
2019-03-25 17:33 ` Basil L. Contovounesios
2019-03-27 17:57 ` Andy Moreton
2019-03-27 18:42 ` Stefan Monnier
2019-03-31 21:47 ` Basil L. Contovounesios
2019-03-25 17:33 ` Basil L. Contovounesios [this message]
2019-03-25 17:55 ` Tadeus Prastowo
2019-03-25 18:13 ` Eric Abrahamsen
2019-03-25 18:14 ` Basil L. Contovounesios
2019-03-25 17:42 ` Lars Ingebrigtsen
2019-03-25 18:13 ` Basil L. Contovounesios
2019-03-25 18:15 ` Eric Abrahamsen
2019-03-25 18:27 ` Basil L. Contovounesios
2019-04-01 23:43 ` Basil L. Contovounesios
2019-04-03 1:49 ` Eric Abrahamsen
2019-04-03 1:59 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2aurh9e.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).