From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Proposed changes to gnus-dup.el
Date: Wed, 03 Apr 2019 02:59:51 +0100 [thread overview]
Message-ID: <871s2jkfvs.fsf@tcd.ie> (raw)
In-Reply-To: <87a7h797u0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 02 Apr 2019 18:49:11 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>>
>>>> On 03/25/19 18:13 PM, Basil L. Contovounesios wrote:
>>>>>
>>>>> I will wait a few more days for people to comment and push the
>>>>> rest of the patch if there are no serious objections.
>>>>
>>>> If I end up backing out the hash-table changes, will this patch still
>>>> apply correctly?
>>>
>>> The original patch I sent will conflict with the hunks where you added
>>> docstrings to gnus-dup-{list,hashtb} and switched from obarray to
>>> hash-table operations.
>>>
>>> It would be easy for me to resolve these minor conflicts, but if that's
>>> going to get in your way of more pressing work, then I'll hold off.
>>> (That's not to say I think you should revert the hash-table changes.)
>>
>> Eric, just to be clear: may I push these minor changes, or would you
>> rather I held off?
>
> Oh, sorry -- I'd assumed you'd already pushed them! They're good to go
> as far as I'm concerned: in for a penny, in for a pound.
Thanks, pushed.
[1: 2bd3e48404]: * lisp/gnus/gnus-dup.el: Use lexical-binding
2019-04-03 02:55:41 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2bd3e484041b2b7ea47c236b86f59610d971b609
--
Basil
prev parent reply other threads:[~2019-04-03 1:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 3:55 Proposed changes to gnus-dup.el Basil L. Contovounesios
2019-03-25 15:59 ` Andy Moreton
2019-03-25 16:50 ` Stefan Monnier
2019-03-25 17:33 ` Basil L. Contovounesios
2019-03-27 17:57 ` Andy Moreton
2019-03-27 18:42 ` Stefan Monnier
2019-03-31 21:47 ` Basil L. Contovounesios
2019-03-25 17:33 ` Basil L. Contovounesios
2019-03-25 17:55 ` Tadeus Prastowo
2019-03-25 18:13 ` Eric Abrahamsen
2019-03-25 18:14 ` Basil L. Contovounesios
2019-03-25 17:42 ` Lars Ingebrigtsen
2019-03-25 18:13 ` Basil L. Contovounesios
2019-03-25 18:15 ` Eric Abrahamsen
2019-03-25 18:27 ` Basil L. Contovounesios
2019-04-01 23:43 ` Basil L. Contovounesios
2019-04-03 1:49 ` Eric Abrahamsen
2019-04-03 1:59 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2jkfvs.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).