From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 17:33:17 +0000 Message-ID: <87r2aurh9e.fsf@tcd.ie> References: <8736nbip4l.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185318"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 18:34:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8TUE-000m3v-Dj for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 18:34:14 +0100 Original-Received: from localhost ([127.0.0.1]:46007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8TUD-0001CL-D2 for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 13:34:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8TTy-0001C5-SC for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:34:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8TTu-00067p-R2 for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:33:56 -0400 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:45563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8TTt-0005v5-71 for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:33:54 -0400 Original-Received: by mail-ed1-x52e.google.com with SMTP id m16so8265976edd.12 for ; Mon, 25 Mar 2019 10:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DCBsISX0tOP5vtf+5jLKXjWTj8NeJGNEHAXcvB5jBr8=; b=vJSHq/037zwMb02an8nrY+UGsTX0gVgSBx2/qWDcpnaWkTajlA6BPckdCYoBuvyTMw +QtSR/k+4paFASFKP+DrdjTHc9gaGgD4P/MlwLgKWuR6/Sfge2305Sjz57VL+DKiZJEu jFZs2pj/yEF0ZAZtOfFZFqqA+7RKAAjVouP12+vkc5zn/ikipY2+eUeEcCv9AFyE0kG+ SwQmVr8Pzzzu++3yw3sVxxcD8FL9ktqWht6nX8LfBE1N6mV5AxP5S8leaHGZySmlXvwx SuPGypoqFM6hT9Ouo8TFyZz7cmaxwuAHuL5wQONSgMmWFdUs1s3SAI7HyxocPSzXG4r3 UnrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DCBsISX0tOP5vtf+5jLKXjWTj8NeJGNEHAXcvB5jBr8=; b=tCMyJAwCZCEqcA9PjJ2T3nzlUr75E6wHDXSIWxIyGazln3ty1i07bf+JqhXE63L76x CKv6ANgMVuAZBD8tOruwwqzyjA5aPHUnxpUrFpE97UYPR0BzgsHMl3XuECTvCfF60nz2 fL9q0uI7V3/ysFkj+0MMcIfN8O6+tlrU3SynLKqFas+fEFvirzy8sx331bcY1eDtAvnj T1NuPwaGNs1/8BC1XkqdHZzd/YSoBJX35nqU0VRWyi46LI0espt8ZCzihFRD38d7rds2 6YmIS+NvUWfF9eAnKS5dsyk28WltB3HiLdg2LQU0JEsvl3BCgHKQZOzN4cuaJQ6Y5cJj Hmvw== X-Gm-Message-State: APjAAAVv+bqm52j2sy0xxudF9MtKSU+Wlz0gYMuHD5ddNq098QfjyZCW m/qsN9/SlrSHdcx6anoTOGQuug== X-Google-Smtp-Source: APXvYqzMu+OyhBOV9axDX+KQCvELxtNNM7xRM/+bFdgPw6gLoUOGX+SUMvhV2u4y9bny+fJHQ47Fww== X-Received: by 2002:a17:906:6c0d:: with SMTP id j13mr14659777ejr.249.1553535199898; Mon, 25 Mar 2019 10:33:19 -0700 (PDT) Original-Received: from localhost ([134.226.214.210]) by smtp.gmail.com with ESMTPSA id p20sm2413489edq.62.2019.03.25.10.33.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 25 Mar 2019 10:33:19 -0700 (PDT) In-Reply-To: (Andy Moreton's message of "Mon, 25 Mar 2019 15:59:15 +0000") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234711 Archived-At: Andy Moreton writes: > On Mon 25 Mar 2019, Basil L. Contovounesios wrote: > >> While looking into bug#34973, bug#34974, and bug#34987, I accumulated >> the attached changes to lisp/gnus/gnus-dup.el which I would like to push >> to master. WDYT? > > Given the games Gnus plays with bindings (see `defvoo' and `deffoo') the > switch to lexical binding for gnus may prove to be complex. There are no such binding constructs in gnus-dup.el, and switching to lexical-binding in this file was simple, as the patch demonstrates. > It would be better to avoid switching to lexical binding for a single > file in gnus: rather, do that as part of a larger effort to switch all > of gnus over to lexical binding. Why would that be better? Enabling lexical-binding in a small, simple file carries little risk of fallout while providing the (admittedly tiny) benefit of bringing us one increment closer to lexical Gnus. Sweeping changes across the whole Gnus system, OTOH, are far more risky, as the recent switch to hash-tables has taught us. I would welcome such a wholesale switch to lexical-binding, but I see no reason or benefit to hold back on one file in the meantime. Thanks, -- Basil