From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Proposed changes to gnus-dup.el
Date: Mon, 25 Mar 2019 11:15:27 -0700 [thread overview]
Message-ID: <87pnqehlc0.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <875zs6rfdx.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 25 Mar 2019 18:13:46 +0000")
On 03/25/19 18:13 PM, Basil L. Contovounesios wrote:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>>> + (unless (or (gnus-data-pseudo-p datum)
>>> + (<= (gnus-data-number datum) 0)
>>
>> I'm against using `unless' on complex logic -- many people get confused
>> when reading it in my experience.
>
> Fair enough.
>
>> The rest looks OK.
>
> Thanks. I will wait a few more days for people to comment and push the
> rest of the patch if there are no serious objections.
If I end up backing out the hash-table changes, will this patch still
apply correctly?
next prev parent reply other threads:[~2019-03-25 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 3:55 Proposed changes to gnus-dup.el Basil L. Contovounesios
2019-03-25 15:59 ` Andy Moreton
2019-03-25 16:50 ` Stefan Monnier
2019-03-25 17:33 ` Basil L. Contovounesios
2019-03-27 17:57 ` Andy Moreton
2019-03-27 18:42 ` Stefan Monnier
2019-03-31 21:47 ` Basil L. Contovounesios
2019-03-25 17:33 ` Basil L. Contovounesios
2019-03-25 17:55 ` Tadeus Prastowo
2019-03-25 18:13 ` Eric Abrahamsen
2019-03-25 18:14 ` Basil L. Contovounesios
2019-03-25 17:42 ` Lars Ingebrigtsen
2019-03-25 18:13 ` Basil L. Contovounesios
2019-03-25 18:15 ` Eric Abrahamsen [this message]
2019-03-25 18:27 ` Basil L. Contovounesios
2019-04-01 23:43 ` Basil L. Contovounesios
2019-04-03 1:49 ` Eric Abrahamsen
2019-04-03 1:59 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnqehlc0.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).