unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: ELPA submission: python-import
Date: Fri, 29 Jul 2022 17:35:55 +0200	[thread overview]
Message-ID: <87r124ue1w.fsf@gmail.com> (raw)
In-Reply-To: <83k07w6j87.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Jul 2022 18:18:00 +0300")

On Fri, 29 Jul 2022 at 18:18, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Fri, 29 Jul 2022 16:15:29 +0200
>> 
>> I would like to submit the following package to ELPA:
>> 
>>     https://github.com/astoff/python-import
>> 
>> Its purpose is to edit the imports at the top of Python files more
>> conveniently.  There are already several packages for this on MELPA.
>> This one relies on the isort program for the editing and code analysis,
>> which is hopefully a reasonably robust solution.
>
> Thanks, but would it perhaps make sense to add this to python-mode
> that we have in core?

I suppose two things speaking against it:

- The package depends on two external tools (isort and pyflakes) that
  are popular but neither built-in nor de facto standards.

- Sometimes the heuristics used there can be wrong (e.g. if relative
  imports (IMHO usually a bad idea anyway) are used).  I haven't used
  the package enough to judge how much of a problem this is.

That said, if someone else gets the chance to give the code a good test
and is convinced by it, I wouldn't mind at all to have it added directly
to python-mode.



  reply	other threads:[~2022-07-29 15:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 14:15 ELPA submission: python-import Augusto Stoffel
2022-07-29 15:18 ` Eli Zaretskii
2022-07-29 15:35   ` Augusto Stoffel [this message]
2022-07-29 16:25     ` Stefan Monnier
2022-07-30  8:56       ` Augusto Stoffel
2022-07-31  3:28       ` Richard Stallman
2022-07-31  9:08         ` Augusto Stoffel
2022-07-29 15:53 ` Philip Kaludercic
2022-07-30  9:07   ` Augusto Stoffel
2022-07-30  9:12     ` Visuwesh
2022-07-30 11:14       ` Augusto Stoffel
2022-07-30 11:58     ` Philip Kaludercic
2022-07-30 19:01       ` Augusto Stoffel
2022-07-31  9:22         ` Philip Kaludercic
2022-07-31  3:32       ` Richard Stallman
2022-07-31  9:20         ` Augusto Stoffel
2022-07-31  9:26         ` Philip Kaludercic
2022-07-31 10:46           ` Stefan Monnier
2022-07-31  3:28   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r124ue1w.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).