unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
Subject: Re: ELPA submission: python-import
Date: Fri, 29 Jul 2022 12:25:53 -0400	[thread overview]
Message-ID: <jwvwnbv7v6m.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r124ue1w.fsf@gmail.com> (Augusto Stoffel's message of "Fri, 29 Jul 2022 17:35:55 +0200")

> I suppose two things speaking against it:
>
> - The package depends on two external tools (isort and pyflakes) that
>   are popular but neither built-in nor de facto standards.
>
> - Sometimes the heuristics used there can be wrong (e.g. if relative
>   imports (IMHO usually a bad idea anyway) are used).  I haven't used
>   the package enough to judge how much of a problem this is.

FWIW, I don't find those to be good reasons to keep the code separate.
It's quite common for some parts of the functionality of a major modes
to be less thorough (e.g. depend on the presence of some unusual tool,
or depend on specific conventions, ...): it's not ideal, but it's better
than nothing, and also makes it "obvious" where to improve the code.
IOW it can encourage further improvements.


        Stefan




  reply	other threads:[~2022-07-29 16:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 14:15 ELPA submission: python-import Augusto Stoffel
2022-07-29 15:18 ` Eli Zaretskii
2022-07-29 15:35   ` Augusto Stoffel
2022-07-29 16:25     ` Stefan Monnier [this message]
2022-07-30  8:56       ` Augusto Stoffel
2022-07-31  3:28       ` Richard Stallman
2022-07-31  9:08         ` Augusto Stoffel
2022-07-29 15:53 ` Philip Kaludercic
2022-07-30  9:07   ` Augusto Stoffel
2022-07-30  9:12     ` Visuwesh
2022-07-30 11:14       ` Augusto Stoffel
2022-07-30 11:58     ` Philip Kaludercic
2022-07-30 19:01       ` Augusto Stoffel
2022-07-31  9:22         ` Philip Kaludercic
2022-07-31  3:32       ` Richard Stallman
2022-07-31  9:20         ` Augusto Stoffel
2022-07-31  9:26         ` Philip Kaludercic
2022-07-31 10:46           ` Stefan Monnier
2022-07-31  3:28   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwnbv7v6m.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=arstoffel@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).