From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: ELPA submission: python-import Date: Fri, 29 Jul 2022 17:35:55 +0200 Message-ID: <87r124ue1w.fsf@gmail.com> References: <87v8rguhry.fsf@gmail.com> <83k07w6j87.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4666"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 29 17:38:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHS4L-00012k-QP for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jul 2022 17:38:29 +0200 Original-Received: from localhost ([::1]:44974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHS4K-0007f4-1v for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Jul 2022 11:38:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHS1y-0005SM-TI for emacs-devel@gnu.org; Fri, 29 Jul 2022 11:36:14 -0400 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:46858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHS1v-0005dk-Vc; Fri, 29 Jul 2022 11:36:02 -0400 Original-Received: by mail-ej1-x62e.google.com with SMTP id ez10so9121050ejc.13; Fri, 29 Jul 2022 08:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version; bh=ZAgmrM5TmuPe5qlt2n08z3yQTb168ckiqI4lmHyAHUE=; b=oB0qOVLZhphl90wWc12U7MyiDAUBFwHRw/w8AWtzBSiKlBFgJa9pbhEL8oVbreYvdI 2ld4uiVAD+ZIT5FPqbpTusZG5Ee4dawNOGVutoN1UAyT/OIG6v0i6XjrWS1yuu2al2Ac Ov7YmXRDsrDK52mX0jFvqqHSiS8wx8ujhWbbkc9NyLTK4bn2mLvDxZAiwQwD5uMH8srE pPueoR9PgPKgkhbk7mcCnjTOF2M5PkKrdrZjnfdHgTxJ91HgIfflFCOGnTSkCakBUxUq PZnagvSF+cCp6/zJBPblPfuSyiEHhZjoh8pak7YFIZ4vYaHU/1TvdBPjPJPbrRk2Z04c 3OGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version; bh=ZAgmrM5TmuPe5qlt2n08z3yQTb168ckiqI4lmHyAHUE=; b=3n+2RCwAXcI8iIs43gd61K57Wm2qpWpvXpcHiSoK6FXo9/LdmgamWfVaEufD3B6BQR mlFFoavLUx37rxorYUBM7XJX71yeBjC66GsmrjXjZb2R6x+S8U+N0YQBMty8h3vMbOcz S4HDO9qqgW14y8rQz8S0o1T3NqNWMKUaji8/eDqAEtUUQ9P7YIQyfv1LNb/8aLBSPsNX cvRjnz8W3kv3hyOgeZvxib1bgHPWUIEAJkbcdJZ5ORRJ+G/FkLiizasPGTbogZJ7RwL4 GDVJQ7NUdbqupfuB/NJgrkvUSGeFBdPrB2F226n/p/ADaq9FvkmTGoDLlW233zBf9inS BMeA== X-Gm-Message-State: AJIora/9oKjSQEYgxiaPB1LvroAw8y7XFVobWG9AB/Jg18JNCK4xlt9O fT5OoM2r+7/ogYD6BmDPyrbVJsJMr15+Bw== X-Google-Smtp-Source: AGRyM1uLcI0YZfq/WC045Zv7Hl9iO8+GNVlXetHqeat8k4172711NXJhCQDEbEmJ2y2o3j/i8OxKMw== X-Received: by 2002:a17:907:2cc8:b0:72b:52b3:68e with SMTP id hg8-20020a1709072cc800b0072b52b3068emr3242363ejc.298.1659108957280; Fri, 29 Jul 2022 08:35:57 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::11cf]) by smtp.gmail.com with ESMTPSA id d17-20020a170906175100b00718e4e64b7bsm1840137eje.79.2022.07.29.08.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 08:35:56 -0700 (PDT) In-Reply-To: <83k07w6j87.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Jul 2022 18:18:00 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292840 Archived-At: On Fri, 29 Jul 2022 at 18:18, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Date: Fri, 29 Jul 2022 16:15:29 +0200 >> >> I would like to submit the following package to ELPA: >> >> https://github.com/astoff/python-import >> >> Its purpose is to edit the imports at the top of Python files more >> conveniently. There are already several packages for this on MELPA. >> This one relies on the isort program for the editing and code analysis, >> which is hopefully a reasonably robust solution. > > Thanks, but would it perhaps make sense to add this to python-mode > that we have in core? I suppose two things speaking against it: - The package depends on two external tools (isort and pyflakes) that are popular but neither built-in nor de facto standards. - Sometimes the heuristics used there can be wrong (e.g. if relative imports (IMHO usually a bad idea anyway) are used). I haven't used the package enough to judge how much of a problem this is. That said, if someone else gets the chance to give the code a good test and is convinced by it, I wouldn't mind at all to have it added directly to python-mode.