From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 11:15:27 -0700 Message-ID: <87pnqehlc0.fsf@ericabrahamsen.net> References: <8736nbip4l.fsf@tcd.ie> <875zs6rfdx.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138338"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 19:24:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8UGY-000Zox-DD for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 19:24:10 +0100 Original-Received: from localhost ([127.0.0.1]:46625 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8UGX-00057d-D9 for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 14:24:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8U8g-0007jv-FY for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:16:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8U8b-000782-4t for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:16:01 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:47570 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8U8Y-0006va-MA for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:15:55 -0400 Original-Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A4DD5FA02A; Mon, 25 Mar 2019 18:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553537729; bh=jKiMsv3z2lWEScQsjmehgXTmXzPvwivazgQIxsaNr78=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Xr/6S72QGXbPLY8VCTc4JrLF03bN2kObqY0k6PdJ3DPTUsMTgxeMoeWrFSEMOUbC5 xVFMF2r5uTkQGvRu/uzAC/sFfJhCxeWxZ6sm57JUh9TD5Lb45XZpQCsAyW4uvJ8wji M3EmYVu2/RtCtBmi6s97oxp+VT+LpxaesQfpp/ng= In-Reply-To: <875zs6rfdx.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 25 Mar 2019 18:13:46 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 52.70.2.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234722 Archived-At: On 03/25/19 18:13 PM, Basil L. Contovounesios wrote: > Lars Ingebrigtsen writes: > >> "Basil L. Contovounesios" writes: >> >>> + (unless (or (gnus-data-pseudo-p datum) >>> + (<= (gnus-data-number datum) 0) >> >> I'm against using `unless' on complex logic -- many people get confused >> when reading it in my experience. > > Fair enough. > >> The rest looks OK. > > Thanks. I will wait a few more days for people to comment and push the > rest of the patch if there are no serious objections. If I end up backing out the hash-table changes, will this patch still apply correctly?