unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: "Mattias Engdegård" <mattiase@acm.org>, emacs-devel@gnu.org
Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment`
Date: Wed, 03 Mar 2021 16:26:26 +0100	[thread overview]
Message-ID: <87pn0gw95p.fsf@gnus.org> (raw)
In-Reply-To: <8735xctggp.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 03 Mar 2021 15:16:54 +0000")

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

>> Maybe the latter doesn't use the byte-compiled version of the tests.
>> Try something like
>>
>>  make TEST_LOAD_EL=no -C test pcase-tests
>
> Indeed, 'make TEST_LOAD_EL=yes test/pcase-tests' succeeds,
> whereas 'make TEST_LOAD_EL=no  test/pcase-tests' fails.

Oh, that explains a lot -- why saying "make foo-tests" often passes while
saying "make check" fails, which has left me scratching my head often.

> Should 'make test/%' be fixed to behave more like 'make check'?

Yes, I think so.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  parent reply	other threads:[~2021-03-03 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210301171853.8051.45984@vcs0.savannah.gnu.org>
     [not found] ` <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org>
2021-03-03 14:44   ` master a0f6029: Fix misuses of `byte-compile-macro-environment` Basil L. Contovounesios
     [not found]     ` <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org>
2021-03-03 15:16       ` Basil L. Contovounesios
2021-03-03 15:23         ` Mattias Engdegård
2021-03-03 15:26         ` Lars Ingebrigtsen [this message]
2021-03-04 13:48           ` Basil L. Contovounesios
2021-03-04  8:41         ` Michael Albinus
2021-03-03 22:15     ` Stefan Monnier
2021-03-04  1:47       ` Basil L. Contovounesios
2021-03-04  2:33         ` Stefan Monnier
2021-03-04 13:38           ` Basil L. Contovounesios
2021-03-04 14:50             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn0gw95p.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).