From: "Mattias Engdegård" <mattiase@acm.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment`
Date: Wed, 3 Mar 2021 16:23:19 +0100 [thread overview]
Message-ID: <3E36FB6A-A691-4CD9-909B-6BF1BCFE4D8A@acm.org> (raw)
In-Reply-To: <8735xctggp.fsf@tcd.ie>
3 mars 2021 kl. 16.16 skrev Basil L. Contovounesios <contovob@tcd.ie>:
> Indeed, 'make TEST_LOAD_EL=yes test/pcase-tests' succeeds,
> whereas 'make TEST_LOAD_EL=no test/pcase-tests' fails.
>
> Should 'make test/%' be fixed to behave more like 'make check'?
Maybe -- test/Makefile.in says:
# Whether to run tests from .el files in preference to .elc, we do
# this by default since it gives nicer stacktraces.
# If you just want a pass/fail, setting this to no is much faster.
export TEST_LOAD_EL ?= \
$(if $(findstring $(MAKECMDGOALS), all check check-maybe),no,yes)
For some tests it may be useful to run both .el and .elc; for others, it's just a waste of time.
My guess is that on balance, .elc is more important (and faster) but obviously .el gives better diagnostics when something fails.
next prev parent reply other threads:[~2021-03-03 15:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210301171853.8051.45984@vcs0.savannah.gnu.org>
[not found] ` <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org>
2021-03-03 14:44 ` master a0f6029: Fix misuses of `byte-compile-macro-environment` Basil L. Contovounesios
[not found] ` <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org>
2021-03-03 15:16 ` Basil L. Contovounesios
2021-03-03 15:23 ` Mattias Engdegård [this message]
2021-03-03 15:26 ` Lars Ingebrigtsen
2021-03-04 13:48 ` Basil L. Contovounesios
2021-03-04 8:41 ` Michael Albinus
2021-03-03 22:15 ` Stefan Monnier
2021-03-04 1:47 ` Basil L. Contovounesios
2021-03-04 2:33 ` Stefan Monnier
2021-03-04 13:38 ` Basil L. Contovounesios
2021-03-04 14:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E36FB6A-A691-4CD9-909B-6BF1BCFE4D8A@acm.org \
--to=mattiase@acm.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).