From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Wed, 03 Mar 2021 16:26:26 +0100 Message-ID: <87pn0gw95p.fsf@gnus.org> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org> <8735xctggp.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40418"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 16:28:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHTQE-000AOq-2d for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 16:28:22 +0100 Original-Received: from localhost ([::1]:38606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHTQC-0004YW-DU for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 10:28:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHTOc-0003d8-SA for emacs-devel@gnu.org; Wed, 03 Mar 2021 10:26:42 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:58162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHTOb-00071M-7p for emacs-devel@gnu.org; Wed, 03 Mar 2021 10:26:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ycKqBMGDSRrC/S/JB1PxT/F1i/DrlD04SpgPXiV3EDs=; b=rIKPAaaYyjL/ryZAOvS04Mf33P TTqRnN6Dcz1d+NaT0fZUxRDAYwyGrHWszYsHZXCLYZhrz4Isfwuri/VbuFxPTtIis7GN4HUV9BCbM ZsT54S/cNqUUuq7b05R0efGa8xMgnE5eexH7Jzc2Sv3xGIBMVu64SKZ2bc4kKhlUzukQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHTOO-0001MZ-GV; Wed, 03 Mar 2021 16:26:38 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEUGBQYnHyhLN0Fl T1iabWNxZoczMFjmza3///8F038LAAAAAWJLR0QIht6VegAAAAd0SU1FB+UDAw8YNpm1v1IAAAGx SURBVDjLjZS9ctswDMeBpPUM0D7O+noAW2LbNYnV49whmcO4xgM0uvL1S0q2RUoeijvdifwBfxAE JID/MmRCVRW3NSEhB0OuwsOUOcel4rpl1dFKqVPd8WdXrlMwmmO1UAKkCJo77uhCjjv6sPkFqPo7 NWgHsD0SAi6UtCPaNmSAlxFvBFjvd0ezPFaQwu3+cbB/1udFBdDWn3dOEMt4fFltT+JNDnAGz6va aWS75+UmU9XtAe1TdrHRlO0K2Pl9VkQEZlAEdkjd9QSeEB78rBTaLHF/F6/wSxKArCNwzYHwwSZn Qjk7ETkdhdAOlILXAGr/KdAMRdq781vwt/5v29hD2o3NawBn740fWqEMSATfvG9FHLsb+BoC5KM9 +UFHwGUGRP94KZvvDrC5NWojo31Uyvqytn4JhBs/WgbceLneDzYHjtChMX3fmX4G8aMBfepa05q6 Mf1hjggfk/xuyRSq5GTeNyGDloqgLmLd+J5GCE+TABwSZskv71oSgPqyQM2SgbgcWz8VOkuFIvS4 pXMQhu3qvAA8qV3tfQaXgHBhFSf/kjA+7qqByJjOw9r+AWwcdot/3M/VAAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIxLTAzLTAzVDE1OjI0OjUzKzAwOjAwOYVvTgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy MS0wMy0wM1QxNToyNDo1MyswMDowMEjY1/IAAAAASUVORK5CYII= X-Now-Playing: Siouxsie and the Banshees's _The Scream_: "Helter Skelter" In-Reply-To: <8735xctggp.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 03 Mar 2021 15:16:54 +0000") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265886 Archived-At: "Basil L. Contovounesios" writes: >> Maybe the latter doesn't use the byte-compiled version of the tests. >> Try something like >> >> make TEST_LOAD_EL=no -C test pcase-tests > > Indeed, 'make TEST_LOAD_EL=yes test/pcase-tests' succeeds, > whereas 'make TEST_LOAD_EL=no test/pcase-tests' fails. Oh, that explains a lot -- why saying "make foo-tests" often passes while saying "make check" fails, which has left me scratching my head often. > Should 'make test/%' be fixed to behave more like 'make check'? Yes, I think so. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no