From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment`
Date: Thu, 04 Mar 2021 01:47:28 +0000 [thread overview]
Message-ID: <87blbzd70v.fsf@tcd.ie> (raw)
In-Reply-To: <jwvtupropl1.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 03 Mar 2021 17:15:59 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Fix misuses of `byte-compile-macro-environment`
>>
>> This seems to result in the following test failure with 'make check',
>> but strangely not with 'make test/pcase-tests':
>
> Hmm... I wonder why the test code worked before that patch.
> The problem is that pcase macros defined with `pcase-defmacro` can't be
> used in the same file where they're defined (you need to wrap them in
> `eval-and-compile`).
> Maybe we should fix that, but the problem is not new, so I'm wondering
> why the bug didn't trigger earlier.
Beats me :/. Even after reverting commits a0f60293d9 and 88ca2280ba,
'make check' still fails. But both 'git bisect', and checking out its
parent 6ad9b8d677, point to a0f60293d9 as being the culprit.
>> BTW, 'make bootstrap' now emits this warning:
>>
>> In cl--sm-macroexpand:
>> emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare'
>
> Yes, that's good: the warning wanrs about an actual problem.
>
>> (The 'sm' is the artist's signature, right? ;)
>
> Nah, the artist found a good excuse: "s(ymbol-)m(acrolet)"
Not the kind of nom de plume you see every day.
>> Is this the right fix?
>
> Yes, but it doesn't just pacify the byte-compiler: it fixes the source
> code (in Emacs-27, this worked by accident, really).
Thanks, pushed with the log message adapted accordingly.
--
Basil
next prev parent reply other threads:[~2021-03-04 1:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210301171853.8051.45984@vcs0.savannah.gnu.org>
[not found] ` <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org>
2021-03-03 14:44 ` master a0f6029: Fix misuses of `byte-compile-macro-environment` Basil L. Contovounesios
[not found] ` <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org>
2021-03-03 15:16 ` Basil L. Contovounesios
2021-03-03 15:23 ` Mattias Engdegård
2021-03-03 15:26 ` Lars Ingebrigtsen
2021-03-04 13:48 ` Basil L. Contovounesios
2021-03-04 8:41 ` Michael Albinus
2021-03-03 22:15 ` Stefan Monnier
2021-03-04 1:47 ` Basil L. Contovounesios [this message]
2021-03-04 2:33 ` Stefan Monnier
2021-03-04 13:38 ` Basil L. Contovounesios
2021-03-04 14:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blbzd70v.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).