Re: master 9dfd945: Fix byte compilation of package built-ins

Re: master 9dfd945: Fix byte compilation of package built-ins

[Lars Ingebrigtsen]

larsi@gnus.org (Lars Ingebrigtsen) writes:

>     (package-test-macro-compilation-gz): Test (bug#49708).

This seems to fail when using native compilation:

Test package-test-macro-compilation-gz backtrace:
  require(macro-builtin)
  (let ((load-path load-path)) (add-to-list 'load-path (directory-file
  (unwind-protect (let ((load-path load-path)) (add-to-list 'load-path
  (let ((dir (expand-file-name "macro-builtin-package-1.0"))) (unwind-
  (progn nil (let ((dir (expand-file-name "macro-builtin-package-1.0")

Which may be a bug in native-comp.

The situation is:  You have a directory (in load-path) with

foo.el.gz
foo.elc

and then say (require 'foo), and that fails?  I haven't tried to debug
further; perhaps it's obvious to somebody what's failing here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 9dfd945: Fix byte compilation of package built-ins

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 10 Nov 2021 02:02:41 +0100
> Cc: dick.r.chiang@gmail.com, Andrea Corallo <akrl@sdf.org>
> 
> Test package-test-macro-compilation-gz backtrace:
>   require(macro-builtin)
>   (let ((load-path load-path)) (add-to-list 'load-path (directory-file
>   (unwind-protect (let ((load-path load-path)) (add-to-list 'load-path
>   (let ((dir (expand-file-name "macro-builtin-package-1.0"))) (unwind-
>   (progn nil (let ((dir (expand-file-name "macro-builtin-package-1.0")
> 
> Which may be a bug in native-comp.
> 
> The situation is:  You have a directory (in load-path) with
> 
> foo.el.gz
> foo.elc
> 
> and then say (require 'foo), and that fails?  I haven't tried to debug
> further; perhaps it's obvious to somebody what's failing here.

Is that a build with built-in compression capabilities?  That is
required for natively-compiling compressed .el files.

Re: master 9dfd945: Fix byte compilation of package built-ins

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> The situation is:  You have a directory (in load-path) with
>> 
>> foo.el.gz
>> foo.elc
>> 
>> and then say (require 'foo), and that fails?  I haven't tried to debug
>> further; perhaps it's obvious to somebody what's failing here.
>
> Is that a build with built-in compression capabilities?  That is
> required for natively-compiling compressed .el files.

Hm...  Oh!  I didn't notice this bit:

Test package-test-macro-compilation-gz condition:
    (file-notify-error "hashing failed" "/home/larsi/src/emacs/trunk/test/lisp/emacs-lisp/package-resources/macro-builtin-package-1.0/macro-builtin.el.gz")

So it passes this test:

static Lisp_Object
comp_hash_source_file (Lisp_Object filename)

[...]

#ifndef HAVE_ZLIB
  if (is_gz)
    xsignal2 (Qfile_notify_error,
	      build_string ("Cannot natively compile compressed *.el files without zlib support"),
	      filename);

But then signals an error here:

#ifdef HAVE_ZLIB
  int res = is_gz
    ? md5_gz_stream (f, SSDATA (digest))
    : md5_stream (f, SSDATA (digest));
#else
  int res = md5_stream (f, SSDATA (digest));
#endif
  fclose (f);

  if (res)
    xsignal2 (Qfile_notify_error, build_string ("hashing failed"), filename);


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 9dfd945: Fix byte compilation of package built-ins

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> #ifdef HAVE_ZLIB
>   int res = is_gz
>     ? md5_gz_stream (f, SSDATA (digest))
>     : md5_stream (f, SSDATA (digest));

The error is in the test -- these aren't really .gz files -- they're
just .el files that have been renamed to .el.gz, which is why it's
failing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no