From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 9dfd945: Fix byte compilation of package built-ins Date: Wed, 10 Nov 2021 04:51:00 +0100 Message-ID: <87r1bois7v.fsf@gnus.org> References: <20211107003051.7974.4876@vcs0.savannah.gnu.org> <20211107003052.D02F720A22@vcs0.savannah.gnu.org> <87mtmckeku.fsf@gnus.org> <83ee7o4r90.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9793"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: akrl@sdf.org, dick.r.chiang@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 10 04:52:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkeeY-0002Ff-PD for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Nov 2021 04:52:02 +0100 Original-Received: from localhost ([::1]:51360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkeeW-0004Hj-QM for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Nov 2021 22:52:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkedi-0003bN-02 for emacs-devel@gnu.org; Tue, 09 Nov 2021 22:51:10 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=56280 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkedg-0004zC-EA; Tue, 09 Nov 2021 22:51:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lRw1sK2oP1wf9frXM2hMv0kAT7DvkvWR/YFZP1OvLrg=; b=gMPiFEUTeWKlninly3eW6zf+xP OJsa7KcnU1pjK2mPtAshy4d82suRIIu6DMmFqTKEYPbTvX/va+SIkO+OzUH35QAZAKn/W3q+dZTKR dRDhzWOGDgJMEYR9+sEeLtMFbOQK7RsL/8b5bX8YiZf9bPRFAIIIauG37h+aTwxM/YJk=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkedZ-0000z3-CG; Wed, 10 Nov 2021 04:51:04 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWvbibcpETgnzHl uDj40UpUDAX6+Mj///9jnu3jAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+ULCgMwF8zj/IkAAAGwSURB VDjLbZRBcoMwDEUdpt7XcAEQdJ9YPgCpPV0zmfoGHe5/hH7JOCQhGkIy//nLkgwx5hCuJTe0B/kE nailg4wgwvWSRaMd8HmjF3jIcwTuOarcDO7zyVN1VPIGNDTI79MBYLlz3TXbF0DFcHGtfHVcASbg wnVbeGEJBdgXlgtcMEAMKQlSQwn2l071FEF2MDJJliShoORScB7VoBYBcoGOxt7g+FmVmLyA9dqm zYufAP4kl8kGFyTAnBcyaV1XGDxWN7bJOTf0BeDtR3U0dlFwIwvAdplNmr8lVV4ybsgCkHE758l+ Gez84sizCfPMI+p83uM3eW1R6rRSFR4YAWbaWpdyH/sYQwVlJNp5b28ppgruk+JA54kT11nJvGuk e2BWb2Q5DjbIwTE9RllmnjIgwkZeQIxcHSHFUFPXNAgPsB9nKGLw3pPheymeFKAaLy0z1yHgKRGF PHEBpdfA0Y9+G4MAVwBHAbSHGRRAxtbxETjNxUGLgtDLGTR9caiIoqKC7YAw3FI+UUjQ72++HgVr 7ZM4zA4I2bgDGKN/IAJc6zuqoN+B/KdIdGXzUu0/oaWkhJEgo4oAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMTEtMTBUMDM6NDg6MjMrMDA6MDBDnjA3AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEx LTEwVDAzOjQ4OjIzKzAwOjAwMsOIiwAAAABJRU5ErkJggg== X-Now-Playing: Kate Bush's _Remastered (8): Aerial: A Sea Of Honey_: "Mrs. Bartolozzi" In-Reply-To: <83ee7o4r90.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Nov 2021 05:35:39 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279144 Archived-At: Eli Zaretskii writes: >> The situation is: You have a directory (in load-path) with >> >> foo.el.gz >> foo.elc >> >> and then say (require 'foo), and that fails? I haven't tried to debug >> further; perhaps it's obvious to somebody what's failing here. > > Is that a build with built-in compression capabilities? That is > required for natively-compiling compressed .el files. Hm... Oh! I didn't notice this bit: Test package-test-macro-compilation-gz condition: (file-notify-error "hashing failed" "/home/larsi/src/emacs/trunk/test/lisp/emacs-lisp/package-resources/macro-builtin-package-1.0/macro-builtin.el.gz") So it passes this test: static Lisp_Object comp_hash_source_file (Lisp_Object filename) [...] #ifndef HAVE_ZLIB if (is_gz) xsignal2 (Qfile_notify_error, build_string ("Cannot natively compile compressed *.el files without zlib support"), filename); But then signals an error here: #ifdef HAVE_ZLIB int res = is_gz ? md5_gz_stream (f, SSDATA (digest)) : md5_stream (f, SSDATA (digest)); #else int res = md5_stream (f, SSDATA (digest)); #endif fclose (f); if (res) xsignal2 (Qfile_notify_error, build_string ("hashing failed"), filename); -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no