From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: akrl@sdf.org, dick.r.chiang@gmail.com, emacs-devel@gnu.org
Subject: Re: master 9dfd945: Fix byte compilation of package built-ins
Date: Wed, 10 Nov 2021 04:51:00 +0100 [thread overview]
Message-ID: <87r1bois7v.fsf@gnus.org> (raw)
In-Reply-To: <83ee7o4r90.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Nov 2021 05:35:39 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> The situation is: You have a directory (in load-path) with
>>
>> foo.el.gz
>> foo.elc
>>
>> and then say (require 'foo), and that fails? I haven't tried to debug
>> further; perhaps it's obvious to somebody what's failing here.
>
> Is that a build with built-in compression capabilities? That is
> required for natively-compiling compressed .el files.
Hm... Oh! I didn't notice this bit:
Test package-test-macro-compilation-gz condition:
(file-notify-error "hashing failed" "/home/larsi/src/emacs/trunk/test/lisp/emacs-lisp/package-resources/macro-builtin-package-1.0/macro-builtin.el.gz")
So it passes this test:
static Lisp_Object
comp_hash_source_file (Lisp_Object filename)
[...]
#ifndef HAVE_ZLIB
if (is_gz)
xsignal2 (Qfile_notify_error,
build_string ("Cannot natively compile compressed *.el files without zlib support"),
filename);
But then signals an error here:
#ifdef HAVE_ZLIB
int res = is_gz
? md5_gz_stream (f, SSDATA (digest))
: md5_stream (f, SSDATA (digest));
#else
int res = md5_stream (f, SSDATA (digest));
#endif
fclose (f);
if (res)
xsignal2 (Qfile_notify_error, build_string ("hashing failed"), filename);
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-10 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211107003051.7974.4876@vcs0.savannah.gnu.org>
[not found] ` <20211107003052.D02F720A22@vcs0.savannah.gnu.org>
2021-11-10 1:02 ` master 9dfd945: Fix byte compilation of package built-ins Lars Ingebrigtsen
2021-11-10 3:35 ` Eli Zaretskii
2021-11-10 3:51 ` Lars Ingebrigtsen [this message]
2021-11-10 3:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1bois7v.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=akrl@sdf.org \
--cc=dick.r.chiang@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).