* Re: [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map
[not found] ` <20220830195811.81C3BC00890@vcs2.savannah.gnu.org>
@ 2022-08-30 20:10 ` Stefan Monnier
2022-08-30 20:11 ` Stefan Monnier
2022-08-30 20:27 ` Niklas Eklund
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Monnier @ 2022-08-30 20:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Niklas Eklund
This `defvar` needs to come before the `define-derived-mode` otherwise
it'll do nothing.
Stfean
ELPA Syncer [2022-08-30 15:58:11] wrote:
> branch: externals/zuul
> commit 785d2d1619245023695daa0a1951749b30c00f30
> Author: Niklas Eklund <niklas.eklund@posteo.net>
> Commit: Niklas Eklund <niklas.eklund@posteo.net>
>
> Add defvar to zuul-log-mode-map
> ---
> zuul.el | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/zuul.el b/zuul.el
> index b7340dc61c..07f4916daf 100644
> --- a/zuul.el
> +++ b/zuul.el
> @@ -1126,17 +1126,19 @@ Optionally provide extra parameters PARAMS, PARSER, METHOD, BUFFER or HEADERS."
> (font-lock-mode)
> (zuul--highlight-cmd))
>
> -(let ((map zuul-log-mode-map))
> - (define-key map (kbd "C-c C-b") #'zuul-switch-build)
> - (define-key map (kbd "C-c C-.") #'eldoc-mode)
> - (define-key map (kbd "C-c ]") #'zuul-next-build)
> - (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser)
> - (define-key map (kbd "C-c [") #'zuul-previous-build)
> - (define-key map (kbd "C-c C-p") #'zuul-previous-command)
> - (define-key map (kbd "C-c C-n") #'zuul-next-command)
> - (define-key map (kbd "C-c C-q") #'zuul-quit-build)
> - (define-key map (kbd "C-c C-s") #'zuul-switch-buildset)
> - (define-key map (kbd "C-c C-r") #'zuul-run-build-command))
> +(defvar zuul-log-mode-map
> + (let ((map (make-sparse-keymap)))
> + (define-key map (kbd "C-c C-b") #'zuul-switch-build)
> + (define-key map (kbd "C-c C-.") #'eldoc-mode)
> + (define-key map (kbd "C-c ]") #'zuul-next-build)
> + (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser)
> + (define-key map (kbd "C-c [") #'zuul-previous-build)
> + (define-key map (kbd "C-c C-p") #'zuul-previous-command)
> + (define-key map (kbd "C-c C-n") #'zuul-next-command)
> + (define-key map (kbd "C-c C-q") #'zuul-quit-build)
> + (define-key map (kbd "C-c C-s") #'zuul-switch-buildset)
> + (define-key map (kbd "C-c C-r") #'zuul-run-build-command)
> + map))
>
> (provide 'zuul)
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map
2022-08-30 20:10 ` [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map Stefan Monnier
@ 2022-08-30 20:11 ` Stefan Monnier
2022-08-31 2:38 ` Richard Stallman
2022-08-30 20:27 ` Niklas Eklund
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2022-08-30 20:11 UTC (permalink / raw)
To: emacs-devel; +Cc: Niklas Eklund
Stefan Monnier [2022-08-30 16:10:25] wrote:
> Stfean
And don't mistype my name, damn it!
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map
2022-08-30 20:10 ` [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map Stefan Monnier
2022-08-30 20:11 ` Stefan Monnier
@ 2022-08-30 20:27 ` Niklas Eklund
1 sibling, 0 replies; 4+ messages in thread
From: Niklas Eklund @ 2022-08-30 20:27 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> This `defvar` needs to come before the `define-derived-mode` otherwise
> it'll do nothing.
Fixed!
>
> Stfean
>
>
> ELPA Syncer [2022-08-30 15:58:11] wrote:
/ Nilkas ;)
>> branch: externals/zuul
>> commit 785d2d1619245023695daa0a1951749b30c00f30
>> Author: Niklas Eklund <niklas.eklund@posteo.net>
>> Commit: Niklas Eklund <niklas.eklund@posteo.net>
>>
>> Add defvar to zuul-log-mode-map
>> ---
>> zuul.el | 24 +++++++++++++-----------
>> 1 file changed, 13 insertions(+), 11 deletions(-)
>>
>> diff --git a/zuul.el b/zuul.el
>> index b7340dc61c..07f4916daf 100644
>> --- a/zuul.el
>> +++ b/zuul.el
>> @@ -1126,17 +1126,19 @@ Optionally provide extra parameters PARAMS, PARSER, METHOD, BUFFER or HEADERS."
>> (font-lock-mode)
>> (zuul--highlight-cmd))
>>
>> -(let ((map zuul-log-mode-map))
>> - (define-key map (kbd "C-c C-b") #'zuul-switch-build)
>> - (define-key map (kbd "C-c C-.") #'eldoc-mode)
>> - (define-key map (kbd "C-c ]") #'zuul-next-build)
>> - (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser)
>> - (define-key map (kbd "C-c [") #'zuul-previous-build)
>> - (define-key map (kbd "C-c C-p") #'zuul-previous-command)
>> - (define-key map (kbd "C-c C-n") #'zuul-next-command)
>> - (define-key map (kbd "C-c C-q") #'zuul-quit-build)
>> - (define-key map (kbd "C-c C-s") #'zuul-switch-buildset)
>> - (define-key map (kbd "C-c C-r") #'zuul-run-build-command))
>> +(defvar zuul-log-mode-map
>> + (let ((map (make-sparse-keymap)))
>> + (define-key map (kbd "C-c C-b") #'zuul-switch-build)
>> + (define-key map (kbd "C-c C-.") #'eldoc-mode)
>> + (define-key map (kbd "C-c ]") #'zuul-next-build)
>> + (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser)
>> + (define-key map (kbd "C-c [") #'zuul-previous-build)
>> + (define-key map (kbd "C-c C-p") #'zuul-previous-command)
>> + (define-key map (kbd "C-c C-n") #'zuul-next-command)
>> + (define-key map (kbd "C-c C-q") #'zuul-quit-build)
>> + (define-key map (kbd "C-c C-s") #'zuul-switch-buildset)
>> + (define-key map (kbd "C-c C-r") #'zuul-run-build-command)
>> + map))
>>
>> (provide 'zuul)
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-31 2:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166188949022.4515.16575956645001384258@vcs2.savannah.gnu.org>
[not found] ` <20220830195811.81C3BC00890@vcs2.savannah.gnu.org>
2022-08-30 20:10 ` [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map Stefan Monnier
2022-08-30 20:11 ` Stefan Monnier
2022-08-31 2:38 ` Richard Stallman
2022-08-30 20:27 ` Niklas Eklund
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).