From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map Date: Tue, 30 Aug 2022 16:10:25 -0400 Message-ID: References: <166188949022.4515.16575956645001384258@vcs2.savannah.gnu.org> <20220830195811.81C3BC00890@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12521"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Niklas Eklund To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 22:11:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT7aM-000353-01 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 22:11:46 +0200 Original-Received: from localhost ([::1]:53636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT7aJ-0007zH-VW for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 16:11:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT7ZG-0007FC-Ia for emacs-devel@gnu.org; Tue, 30 Aug 2022 16:10:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT7ZC-0003Om-JD for emacs-devel@gnu.org; Tue, 30 Aug 2022 16:10:37 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 20AF48089E; Tue, 30 Aug 2022 16:10:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 89AAF8076B; Tue, 30 Aug 2022 16:10:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661890230; bh=iT8pmGtgDuI4cf/EbnN2laJpJUo9GuQjdkQpEnfL6Jc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Vs0JWOu0sMe6jZt2Kz4sYFocGqtWs+crPhRn/n+GChSxOJ4YXmMHrbPIbU/SkK+dZ ujEdqx80LYRCQO9zee4GlN5d9K5CQAGCB9P7DWU69pYKZu/FzwSWk31L4VRWHltymw TbiE/gbKSwPLCuy4ljkVfcQYVJm1e7qT/eN164rsjvf8nD4ZfXZhnRxuMkAU7e2Jan YqANBVEZ6k5yXR7C/SxoRwiJjPw3JpyuA0aspwqpaLH6qdzEi2caGoF2UQSSpA+quT CwBUgtOHR2E0UO1rJU/NPU5HO6oQMbz5sl/A5S6LyGFvICBYHbGKmG1oMmgmmwoYI+ LPGXQ6Zmp4YOg== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4F59D1205FC; Tue, 30 Aug 2022 16:10:30 -0400 (EDT) In-Reply-To: <20220830195811.81C3BC00890@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Tue, 30 Aug 2022 15:58:11 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294382 Archived-At: This `defvar` needs to come before the `define-derived-mode` otherwise it'll do nothing. Stfean ELPA Syncer [2022-08-30 15:58:11] wrote: > branch: externals/zuul > commit 785d2d1619245023695daa0a1951749b30c00f30 > Author: Niklas Eklund > Commit: Niklas Eklund > > Add defvar to zuul-log-mode-map > --- > zuul.el | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/zuul.el b/zuul.el > index b7340dc61c..07f4916daf 100644 > --- a/zuul.el > +++ b/zuul.el > @@ -1126,17 +1126,19 @@ Optionally provide extra parameters PARAMS, PARSER, METHOD, BUFFER or HEADERS." > (font-lock-mode) > (zuul--highlight-cmd)) > > -(let ((map zuul-log-mode-map)) > - (define-key map (kbd "C-c C-b") #'zuul-switch-build) > - (define-key map (kbd "C-c C-.") #'eldoc-mode) > - (define-key map (kbd "C-c ]") #'zuul-next-build) > - (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser) > - (define-key map (kbd "C-c [") #'zuul-previous-build) > - (define-key map (kbd "C-c C-p") #'zuul-previous-command) > - (define-key map (kbd "C-c C-n") #'zuul-next-command) > - (define-key map (kbd "C-c C-q") #'zuul-quit-build) > - (define-key map (kbd "C-c C-s") #'zuul-switch-buildset) > - (define-key map (kbd "C-c C-r") #'zuul-run-build-command)) > +(defvar zuul-log-mode-map > + (let ((map (make-sparse-keymap))) > + (define-key map (kbd "C-c C-b") #'zuul-switch-build) > + (define-key map (kbd "C-c C-.") #'eldoc-mode) > + (define-key map (kbd "C-c ]") #'zuul-next-build) > + (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser) > + (define-key map (kbd "C-c [") #'zuul-previous-build) > + (define-key map (kbd "C-c C-p") #'zuul-previous-command) > + (define-key map (kbd "C-c C-n") #'zuul-next-command) > + (define-key map (kbd "C-c C-q") #'zuul-quit-build) > + (define-key map (kbd "C-c C-s") #'zuul-switch-buildset) > + (define-key map (kbd "C-c C-r") #'zuul-run-build-command) > + map)) > > (provide 'zuul) >